search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

OCPBUGS-33184: Fix incorrect name for hostmount-anyuid SCC ClusterRole #1671

Closed cblecker closed 6 months ago

cblecker commented 7 months ago

The SCC is named "hostmount-anyuid", and not just "hostmount", so I'm not sure this cluster role ever worked correctly.

openshift-ci-robot commented 7 months ago

@cblecker: This pull request references Jira Issue OCPBUGS-33184, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1671): >The SCC is named "hostmount-anyuid", and not just "hostmount", so I'm not sure this cluster role ever worked correctly. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cblecker commented 7 months ago

/jira refresh

openshift-ci-robot commented 7 months ago

@cblecker: This pull request references Jira Issue OCPBUGS-33184, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @xingxingxia

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1671#issuecomment-2089354759): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cblecker commented 7 months ago

/retest-required

stlaz commented 7 months ago

/hold see https://github.com/openshift/cluster-kube-apiserver-operator/pull/1340#issuecomment-1105569183 why this isn't as easy as changing the name @dinhxuanvu Have your fix ever made it to a PR?

dinhxuanvu commented 7 months ago

/hold see #1340 (comment) why this isn't as easy as changing the name @dinhxuanvu Have your fix ever made it to a PR?

Unfortunately, I never got a chance to work on it so there was no PR.

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [dinhxuanvu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cblecker commented 6 months ago

/hold cancel /cherrypick release-4.15 release-4.14 release-4.13

openshift-cherrypick-robot commented 6 months ago

@cblecker: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1671#issuecomment-2093572504): >/hold cancel >/cherrypick release-4.15 release-4.14 release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 6 months ago

/retest-required

Remaining retests: 0 against base HEAD 1d9a2d0d604601640d318ea0cf973d23d711e970 and 2 for PR HEAD 7b66bf3bb4915886ae842461ab5ffd3c77335e05 in total

cblecker commented 6 months ago

/test k8s-e2e-gcp

openshift-ci[bot] commented 6 months ago

@cblecker: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node 7b66bf3bb4915886ae842461ab5ffd3c77335e05 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 7b66bf3bb4915886ae842461ab5ffd3c77335e05 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-metal-single-node-live-iso 7b66bf3bb4915886ae842461ab5ffd3c77335e05 link false /test e2e-metal-single-node-live-iso

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 6 months ago

@cblecker: Jira Issue OCPBUGS-33184: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33184 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1671): >The SCC is named "hostmount-anyuid", and not just "hostmount", so I'm not sure this cluster role ever worked correctly. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 6 months ago

@cblecker: new pull request created: #1672

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1671#issuecomment-2093572504): >/hold cancel >/cherrypick release-4.15 release-4.14 release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.17.0-202405040320.p0.g8fae6b5.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator. All builds following this will include this PR.

openshift-merge-robot commented 6 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-05-04-214435