openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

Provide Labels and/or Units for Ordinates? #1728

Open martin-aders opened 2 months ago

martin-aders commented 2 months ago

On the Grafana dashboards in OpenShift, I wonder why the ordinates are not labeled. Example: "API Request Duration by Verb - 99th Percentile" metric had a peak of "4" on a cluster. Now I'm used to read response times in milliseconds. Only when opening the details via "Inspect" in a separate tab I see that the metric rather uses seconds instead of milliseconds. "4ms" is less worrying than "4s" for a response time. Is there a specific reason that axes are never labeled? Either axis labels or unit names would help to read the charts more quickly without zooming into each metric separately.

https://github.com/openshift/cluster-kube-apiserver-operator/blob/37df1b1f80d3be6036b9e31975ac42fcb21b6447/manifests/0000_90_kube-apiserver-operator_05_api_performance_dashboard.yaml#L139