search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

starter.go: make apply function private #1741

Closed p0lyn0mial closed 2 months ago

p0lyn0mial commented 2 months ago

/assign @bertinatto

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
p0lyn0mial commented 2 months ago

turns out these functions are used in multiple places.

/close

openshift-ci[bot] commented 2 months ago

@p0lyn0mial: Closed this PR.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1741#issuecomment-2376661805): >turns out these functions are used in multiple places. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/k8s-e2e-gcp-serial a910d4730883594b44873091526a28d714fa0609 link false /test k8s-e2e-gcp-serial
ci/prow/verify a910d4730883594b44873091526a28d714fa0609 link true /test verify
ci/prow/e2e-metal-single-node-live-iso a910d4730883594b44873091526a28d714fa0609 link false /test e2e-metal-single-node-live-iso
ci/prow/k8s-e2e-gcp a910d4730883594b44873091526a28d714fa0609 link true /test k8s-e2e-gcp
ci/prow/images a910d4730883594b44873091526a28d714fa0609 link true /test images
ci/prow/e2e-gcp-operator-single-node a910d4730883594b44873091526a28d714fa0609 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-gcp-operator a910d4730883594b44873091526a28d714fa0609 link true /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).