search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

pull https://github.com/openshift/library-go/pull/1819 #1751

Closed p0lyn0mial closed 1 month ago

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
p0lyn0mial commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 70fc8de29a9f2e7262848aede786bfcd9b692da6 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-operator-single-node 70fc8de29a9f2e7262848aede786bfcd9b692da6 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 70fc8de29a9f2e7262848aede786bfcd9b692da6 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator 70fc8de29a9f2e7262848aede786bfcd9b692da6 link true /test e2e-gcp-operator
ci/prow/e2e-aws-ovn-single-node 70fc8de29a9f2e7262848aede786bfcd9b692da6 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn 70fc8de29a9f2e7262848aede786bfcd9b692da6 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial 70fc8de29a9f2e7262848aede786bfcd9b692da6 link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
p0lyn0mial commented 1 month ago

ok, i manually checked the audit-logs form and requests to /livez are no longer persisted in the audit logs.

However I noticed the following entries:

{"kind":"Event","apiVersion":"audit.k8s.io/v1","level":"Metadata","auditID":"fb6a08f8-3656-4435-899a-74dee6416bf1","stage":"ResponseComplete","requestURI":"/readyz","verb":"get","user":{"username":"system:apiserver","uid":"45190fa5-6708-486e-9522-40785dec4762","groups":["system:masters"]},"sourceIPs":["::1"],"userAgent":"kube-apiserver/v1.31.1 (linux/amd64) kubernetes/8540bd4","responseStatus":{"metadata":{},"code":500},"requestReceivedTimestamp":"2024-10-07T09:40:42.005730Z","stageTimestamp":"2024-10-07T09:40:42.006133Z","annotations":{"authorization.k8s.io/decision":"allow","authorization.k8s.io/reason":""}}

which indicates that the requests from the self-client are not matching the audit policy. I am not sure why the self-client queries the /readyz endpoint, but we could update the audit policy to exclude requests from this user to the health check endpoints.

deads2k commented 1 month ago

which indicates that the requests from the self-client are not matching the audit policy. I am not sure why the self-client queries the /readyz endpoint, but we could update the audit policy to exclude requests from this user to the health check endpoints.

Don't exclude the entire user, we need to know what that user does. Weird that it escapes policy though.

p0lyn0mial commented 1 month ago

/close

will pull the fix into https://github.com/openshift/cluster-kube-apiserver-operator/pull/1750

openshift-ci[bot] commented 1 month ago

@p0lyn0mial: Closed this PR.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1751#issuecomment-2413814814): >/close > >will pull the fix into https://github.com/openshift/cluster-kube-apiserver-operator/pull/1750 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.