search

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

OpenShift NFD extendedResources for SGX on 4.14 #358

Closed vbedida79 closed 1 month ago

vbedida79 commented 6 months ago

Summary

We use 4.14.0-202402081809 NFD operator version on OCP 4.14.11. This does not add theNFD extendedResources for SGX EPC with the NodeFeatureRule.

Details

  1. For 4.14.0-202402081809 NFD operator version on OCP 4.14.11, we use the NFR instance to add the SGX EPC sgx.intel.com/epc resource on the node (this was previously done with help of SGX device plugin's init container). The NFR does not create the SGX EPC resource on the node. Is the extendedResources option for EPC not supported for this operator version? Please confirm, thanks.

  2. For the 4.14.0-202402081809 NFD operator version, we use the SGX init container along with NFD instance and NFR instance - for the SGX EPC sgx.intel.com/epc resource on the node. This works as expected with all current files, but if quay image for NFD is updated to 4.14, the resource is not created. It only works for image tag 4.13 on OCP 4.14 as well.

The feature is supported on upstream NFD https://github.com/kubernetes-sigs/node-feature-discovery/pull/1129, is it yet to be supported on OCP 4.14? Please confirm and suggest. Also when would this be supported on OCP? Thanks!

openshift-bot commented 3 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 2 months ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 1 month ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 1 month ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/cluster-nfd-operator/issues/358#issuecomment-2272367464): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.