search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

[release-4.14] OCPBUGS-25137: Add a '.snyk' to silence static code analysis warnings #1002

Closed rbaturov closed 5 months ago

rbaturov commented 8 months ago

The '.snyk' exclude these paths under the vendor directory:

ginkgo/v2/internal/suite.go controller-runtime/pkg/log/log.go jaypipes/ghw/pkg/block/block_linux.go

These paths trigger a warning related to the generation of error messages containing sensitive information. Currently, there is no available fix for these issues.

openshift-ci-robot commented 8 months ago

@rbaturov: This pull request references Jira Issue OCPBUGS-25137, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1002): >The '.snyk' exclude these paths under the vendor directory: > >ginkgo/v2/internal/suite.go >controller-runtime/pkg/log/log.go >jaypipes/ghw/pkg/block/block_linux.go > >These paths trigger a warning related to the generation of error messages containing sensitive information. >Currently, there is no available fix for these issues. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 8 months ago

Thank you for the PR. /approve /lgtm

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, rbaturov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.14/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rbaturov commented 8 months ago

/retest-required

rbaturov commented 8 months ago

/retest-required

rbaturov commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@rbaturov: This pull request references Jira Issue OCPBUGS-25137, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1002#issuecomment-2139239168): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rbaturov commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@rbaturov: This pull request references Jira Issue OCPBUGS-25137, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1002#issuecomment-2139243387): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rbaturov commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@rbaturov: This pull request references Jira Issue OCPBUGS-25137, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-28368](https://issues.redhat.com//browse/OCPBUGS-28368) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-28368](https://issues.redhat.com//browse/OCPBUGS-28368) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

Requesting review from QA contact: /cc @mrniranjan

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1002#issuecomment-2139250443): > >/jira refresh > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
MarSik commented 5 months ago

/label backport-risk-assessed

mrniranjan commented 5 months ago

/label cherry-pick-approved

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD ce4b975b395cae629f120934326d9b1a9a75d0a3 and 2 for PR HEAD 9acb50b973d7992bf3df3ab72836867d3a10c4e8 in total

jmencak commented 5 months ago

These paths trigger a warning related to the generation of error messages containing sensitive information. Currently, there is no available fix for these issues.

Just a question, how did you learn that these needed to be excluded?

rbaturov commented 5 months ago

These paths trigger a warning related to the generation of error messages containing sensitive information. Currently, there is no available fix for these issues.

Just a question, how did you learn that these needed to be excluded?

In the issue attached, you can view the scan results.

rbaturov commented 5 months ago

/retest-required

openshift-ci[bot] commented 5 months ago

@rbaturov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 5 months ago

@rbaturov: Jira Issue OCPBUGS-25137: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25137 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1002): >The '.snyk' exclude these paths under the vendor directory: > >ginkgo/v2/internal/suite.go >controller-runtime/pkg/log/log.go >jaypipes/ghw/pkg/block/block_linux.go > >These paths trigger a warning related to the generation of error messages containing sensitive information. >Currently, there is no available fix for these issues. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.14.0-202406060838.p0.gd1894c1.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.