search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

[release-4.13] OCPBUGS-31357: irqbalance: set banned cpus list to 0 #1003

Closed yanirq closed 8 months ago

yanirq commented 8 months ago

Manual cherry-pick of https://github.com/openshift/cluster-node-tuning-operator/pull/994

yanirq commented 8 months ago

/jira cherrypick OCPBUGS-30980

openshift-ci-robot commented 8 months ago

@yanirq: Jira Issue OCPBUGS-30980 has been cloned as Jira Issue OCPBUGS-31357. Will retitle bug to link to clone. /retitle OCPBUGS-31357: irqbalance: set banned cpus list to 0

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1003#issuecomment-2017878023): >/jira cherrypick OCPBUGS-30980 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 8 months ago

@yanirq: This pull request references Jira Issue OCPBUGS-31357, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1003): >Empty irqbalance ban list means that irqbalance will be calculated by default. The default will exclude all isolated and nohz_full cpus from the mask resulting in the irq’s being balanced over the reserved cpus only, breaking the user intent. > >CPU numbers which have their corresponding bits set to one in the ban mask will not have any irq's assigned to them on rebalance. Then we should set the mask to zero, so all cpus will participate in load balancing. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.13/OWNERS)~~ [yanirq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 8 months ago

/uncc @marioferh /cc @Tal-or

yanirq commented 8 months ago

/retest-required

yanirq commented 8 months ago

/label backport-risk-assessed

Tal-or commented 8 months ago

/lgtm /retest

openshift-ci[bot] commented 8 months ago

@yanirq: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yanirq commented 8 months ago

/jira refresh

openshift-ci-robot commented 8 months ago

@yanirq: This pull request references Jira Issue OCPBUGS-31357, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.z) matches configured target version for branch (4.13.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-30980](https://issues.redhat.com//browse/OCPBUGS-30980) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-30980](https://issues.redhat.com//browse/OCPBUGS-30980) targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (snarula@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1003#issuecomment-2022385214): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
SargunNarula commented 8 months ago

/label cherry-pick-approved

openshift-ci[bot] commented 8 months ago

@SargunNarula: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1003#issuecomment-2022436295): >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shajmakh commented 8 months ago

/label cherry-pick-approved

openshift-ci-robot commented 8 months ago

@yanirq: Jira Issue OCPBUGS-31357: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31357 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1003): >Manual cherry-pick of https://github.com/openshift/cluster-node-tuning-operator/pull/994 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanirq commented 8 months ago

/cherry-pick release-4.12

openshift-cherrypick-robot commented 8 months ago

@yanirq: new pull request created: #1006

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1003#issuecomment-2022526646): >/cherry-pick release-4.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.13.0-202403270740.p0.gc6ed498.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.