search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: Update tuned profile degraded test #1005

Closed rbaturov closed 8 months ago

rbaturov commented 8 months ago

Updated the tuned degradation test to fail only when the tuned profile was found degraded on BM host. In case of tuned profile found degraded on a VM, only a warning would be reported in the logs. The reason for that is that the fact CI is using VMs - and some configurations like certain kernel args can't be applied and therby lead to the tuned profile being degraded.

jmencak commented 8 months ago

/approve /lgtm

Thank you for the PR.

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, rbaturov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 8 months ago

/retest check flakiness.

rbaturov commented 8 months ago

@jmencak @yanirq Can you please review the newly applied changes?

openshift-ci-robot commented 8 months ago

@rbaturov: This pull request references Jira Issue OCPBUGS-23167, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1005): >Updated the tuned degradation test to fail only when the tuned profile was found degraded >on BM host. >In case of tuned profile found degraded on a VM, only a warning would be reported in the logs. >The reason for that is that the fact CI is using VMs - and some >configurations like certain kernel args can't be applied and therby lead to >the tuned profile being degraded. >Slack thread: >https://redhat-internal.slack.com/archives/CQNBUEVM2/p1711429034479449?thread_ts=1711391528.837059&cid=CQNBUEVM2 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 8 months ago

@rbaturov: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1005): >Updated the tuned degradation test to fail only when the tuned profile was found degraded >on BM host. >In case of tuned profile found degraded on a VM, only a warning would be reported in the logs. >The reason for that is that the fact CI is using VMs - and some >configurations like certain kernel args can't be applied and therby lead to >the tuned profile being degraded. >Slack thread: >https://redhat-internal.slack.com/archives/CQNBUEVM2/p1711429034479449?thread_ts=1711391528.837059&cid=CQNBUEVM2 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanirq commented 8 months ago

/retitle NO-JIRA: Update tuned profile degraded test

openshift-ci-robot commented 8 months ago

@rbaturov: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1005): >Updated the tuned degradation test to fail only when the tuned profile was found degraded >on BM host. >In case of tuned profile found degraded on a VM, only a warning would be reported in the logs. >The reason for that is that the fact CI is using VMs - and some >configurations like certain kernel args can't be applied and therby lead to >the tuned profile being degraded. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanirq commented 8 months ago

/lgtm

openshift-ci[bot] commented 8 months ago

@rbaturov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202403280418.p0.g8d02255.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.