search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

CNF-10873: set Cgroups V2 as default #1010

Closed yanirq closed 7 months ago

yanirq commented 7 months ago

On fresh installations cgroups v2 will be the default as Openshift.

Remove helper annotation that sets the cluster to V2 since its not needed anymore.

Reverts https://github.com/openshift/cluster-node-tuning-operator/pull/737 , https://github.com/openshift/cluster-node-tuning-operator/pull/854 (Partially)

openshift-ci-robot commented 7 months ago

@yanirq: This pull request references CNF-10873 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1010): >On fresh installations cgroups v2 will be the default as Openshift. > >Remove helper annotation that sets the cluster to V2 since its not needed anymore. > >Reverts https://github.com/openshift/cluster-node-tuning-operator/pull/737 , https://github.com/openshift/cluster-node-tuning-operator/pull/854 (Partially) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanirq commented 7 months ago

/cc @ffromani @MarSik @Tal-or @mrniranjan

openshift-ci[bot] commented 7 months ago

@yanirq: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik,yanirq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MarSik commented 7 months ago

/hold for others to take a look

ffromani commented 7 months ago

/lgtm

MarSik commented 7 months ago

/hold cancel

openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202404120544.p0.g158afb2.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.