openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: 4.16 go deps #1042

Closed jmencak closed 7 months ago

jmencak commented 7 months ago

This change bumps go dependencies prior to 4.16 release and updates k8s dependencies to 1.29.4.

What I've done:

$ go get -u ./...
$ # pin all dependencies so that the project compiles and tests pass
$ go mod tidy
$ go mod vendor
openshift-ci-robot commented 7 months ago

@jmencak: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1042): >This change bumps go dependencies prior to 4.16 release and updates k8s dependencies to 1.29.4. > >``` >What I've done: > >$ go get -u ./... >$ # pin all dependencies so that the project compiles and tests pass >$ go mod tidy >$ go mod vendor >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jmencak commented 7 months ago

/retest

openshift-ci[bot] commented 7 months ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jmencak commented 7 months ago

This is a change that should merge prior to 26th April in my view. I've tried to clean up go.mod and bump as many dependencies as possible. As the bot-suggested reviewers are off, inviting /cc @swatisehgal /cc @ffromani for review.

jmencak commented 7 months ago

Unholding so that this can pass through the (hypershift and other) e2e tests and merge by Friday... /hold cancel

openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202404240511.p0.g3ddabbf.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.