search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: perfprof: e2e: account for node base load #1047

Closed shajmakh closed 6 months ago

shajmakh commented 7 months ago

Currently the test would fail when tested on machines with exactly isolated cpus equal to the requested cpus by the pod. This is because the worker nodes has already other pods running on them and thus they are using already a portion of the isolated cpus of the node. Scheduling a pod requesting all allocatable cpus would fail due to insufficient cpus on node.

Skip the test if the testing environment is not suitable for the test's requirements.

shajmakh commented 7 months ago

blocking: https://github.com/openshift/release/pull/47439

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shajmakh commented 7 months ago

/retest

openshift-ci-robot commented 7 months ago

@shajmakh: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1047): >Currently the test would fail when tested on machines with exactly isolated cpus equal to the requested cpus by the pod. This is because the worker nodes has already other pods running on them and thus they are using already a portion of the isolated cpus of the node. Scheduling a pod requesting all allocatable cpus would fail due to insufficient cpus on node. > >Skip the test if the testing environment is not suitable for the test's requirements. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
shajmakh commented 7 months ago

/retest

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD dd2698c43517191d17dc5c4ac842e6d4dc3aab32 and 2 for PR HEAD 21428e0a2763c4737a396b7b4c173faa53d5c039 in total

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD d55e5f69c9dfe36872a0297eedf4dc9cd53b19d6 and 1 for PR HEAD 21428e0a2763c4737a396b7b4c173faa53d5c039 in total

openshift-ci-robot commented 6 months ago

/retest-required

Remaining retests: 0 against base HEAD 722642ef945b4883ab3f266b7005025d7371bf5d and 0 for PR HEAD 21428e0a2763c4737a396b7b4c173faa53d5c039 in total

openshift-ci[bot] commented 6 months ago

@shajmakh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202404291018.p0.g163236c.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.