search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-33030: [release-4.13][manual]Reduce number of reboots in offline tests #1048

Closed mrniranjan closed 6 months ago

mrniranjan commented 7 months ago

OCPBUGS-29595: Reduce number of reboots in offline tests (#940)

Currently in offline tests we rever to original profile after each tests, this is very costly and causing tests to run for long time.

This patch addresses by reverting to the profile after all offline tests are run.

openshift-ci-robot commented 7 months ago

@mrniranjan: This pull request references Jira Issue OCPBUGS-33030, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.z) matches configured target version for branch (4.13.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-32207](https://issues.redhat.com//browse/OCPBUGS-32207) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-32207](https://issues.redhat.com//browse/OCPBUGS-32207) targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z * bug has dependents

Requesting review from QA contact: /cc @gsr-shanks

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1048): >OCPBUGS-29595: Reduce number of reboots in offline tests (#940) > >* Reduce number of reboots in offline tests > >Currently in offline tests we rever to original profile after each tests, this is very costly and causing tests to run for long time. > >This patch addresses by reverting to the profile after all offline tests are run. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
mrniranjan commented 7 months ago

/test e2e-upgrade

mrniranjan commented 6 months ago

/test e2e-upgrade

openshift-ci[bot] commented 6 months ago

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ffromani commented 6 months ago

/approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.13/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 6 months ago

/lgtm /label backport-risk-assessed

mrniranjan commented 6 months ago

/label cherry-pick-approved

openshift-ci-robot commented 6 months ago

@mrniranjan: Jira Issue OCPBUGS-33030: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33030 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1048): >OCPBUGS-29595: Reduce number of reboots in offline tests (#940) > >* Reduce number of reboots in offline tests > >Currently in offline tests we rever to original profile after each tests, this is very costly and causing tests to run for long time. > >This patch addresses by reverting to the profile after all offline tests are run. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.13.0-202405161037.p0.g3ed7876.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.

openshift-merge-robot commented 6 months ago

Fix included in accepted release 4.13.0-0.nightly-2024-05-16-131307