search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-33112: E2E: Add automation to check default cpuset from cpu manager state file #1050

Closed mrniranjan closed 6 months ago

mrniranjan commented 6 months ago

Add new automation to verify default cpuset from the cpu manager state file pre and post kubelet restart Automates https://issues.redhat.com/browse/OCPBUGS-24366

mrniranjan commented 6 months ago

/retest-required

openshift-ci-robot commented 6 months ago

@mrniranjan: This pull request references Jira Issue OCPBUGS-33112, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @gsr-shanks

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1050): >Add new automation to verify default cpuset from the cpu manager state file pre and post kubelet restart Automates https://issues.redhat.com/browse/OCPBUGS-24366 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ffromani commented 6 months ago

looks reasonnable and automates the bug per subject, but anything which consumes the state files directly is tech debt and we need to treat is as such.

mrniranjan commented 6 months ago

@ffromani i have modified the test case to check with a gu pod which was the original issue.

ffromani commented 6 months ago

@ffromani i have modified the test case to check with a gu pod which was the original issue.

thanks, but the main issue remains. I guess we don't have better approaches handy, though. We need to start doing these checks using supported APIs, like the podresources API

mrniranjan commented 6 months ago

/retest-required

mrniranjan commented 6 months ago

/test e2e-gcp-pao

mrniranjan commented 6 months ago

@ffromani i have modified the test case to check with a gu pod which was the original issue.

thanks, but the main issue remains. I guess we don't have better approaches handy, though. We need to start doing these checks using supported APIs, like the podresources API

@ffromani okay so if i understand correctly we can use podResources API to fetch defaultCpuSet instead of reading the state file ? Is there any API documentation that i can refer to ?

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 6 months ago

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 6 months ago

@mrniranjan: Jira Issue OCPBUGS-33112: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33112 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1050): >Add new automation to verify default cpuset from the cpu manager state file pre and post kubelet restart Automates https://issues.redhat.com/browse/OCPBUGS-24366 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.