search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: E2E: modify test use HaveKey matchter instead of ContainElement #1056

Closed mrniranjan closed 6 months ago

mrniranjan commented 6 months ago

Using ContainElement causes test to fail as it checks the map contains an Element with node.Name , however in the case map[string]map[string]int, where the node.Name contains hostname:{dev:N, dev:N}, the match fails.

HaveKey specifically checks if the map has the Key with node.Name

openshift-ci-robot commented 6 months ago

@mrniranjan: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1056): >Using ContainElement causes test to fail as it checks the map contains an Element with node.Name , however in the case map[string]map[string]int, where the node.Name contains hostname:{dev:N, dev:N}, the match fails. > >HaveKey specifically checks if the map has the Key with node.Name Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 6 months ago

/retest-required

Remaining retests: 0 against base HEAD a7f1691c7f5cfb67838a4f0e40b3f53da3802f95 and 2 for PR HEAD 2066f75ec4071fe96191572276883388c2640a88 in total

mrniranjan commented 6 months ago

/retest-required

openshift-ci[bot] commented 6 months ago

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202405100946.p0.g05a6864.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.