search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-33682: right-hand-side profile_dirs take precedence #1061

Closed jmencak closed 6 months ago

jmencak commented 6 months ago

The new TuneD option profile_dirs defines custom TuneD directories. Fix the order of the directories so that the system TuneD directory (/usr/lib/tuned) is the first one (searched last), and the custom TuneD directory (/var/lib/ocp-tuned/profiles) is the last one (searched first).

Resolves: OCPBUGS-33682

openshift-ci-robot commented 6 months ago

@jmencak: This pull request references Jira Issue OCPBUGS-33682, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1061): >The new TuneD option profile_dirs defines custom TuneD directories. Fix the order of the directories so that the system TuneD directory (/usr/lib/tuned) is the first one (searched last), and the custom TuneD directory (/var/lib/ocp-tuned/profiles) is the last one (searched first). > >Resolves: OCPBUGS-33682 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 6 months ago

@jmencak: This pull request references Jira Issue OCPBUGS-33682, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1061): >The new `TuneD` option `profile_dirs` defines custom `TuneD` directories. Fix the order of the directories so that the system TuneD directory (`/usr/lib/tuned`) is the first one (searched last), and the custom `TuneD` directory (`/var/lib/ocp-tuned/profiles`) is the last one (searched first). > >Resolves: OCPBUGS-33682 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 6 months ago

/retest

jmencak commented 6 months ago

/retest

jmencak commented 6 months ago

Tested with 

apiVersion: tuned.openshift.io/v1
kind: Tuned
metadata:
  name: provider-aws
  namespace: openshift-cluster-node-tuning-operator
spec:
  profile:
  - data: |
      [main]
      summary=OpenShift profile to test Cloud provider-specific functionality
      [sysctl]
      kernel.pty.max=8192
    name: provider-aws

Works fine. /cc @liqcui

jmencak commented 6 months ago

/label acknowledge-critical-fixes-only

liqcui commented 6 months ago

/lgtm Pre-merge testing passed for cluster-provider feature, thank you for quickly resolving this problem.

openshift-ci[bot] commented 6 months ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 6 months ago

@jmencak: Jira Issue OCPBUGS-33682: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33682 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1061): >The new `TuneD` option `profile_dirs` defines custom `TuneD` directories. Fix the order of the directories so that the system TuneD directory (`/usr/lib/tuned`) is the first one (searched last), and the custom `TuneD` directory (`/var/lib/ocp-tuned/profiles`) is the last one (searched first). > >Resolves: OCPBUGS-33682 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202405202113.p0.gd8c9230.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.

jmencak commented 5 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 5 months ago

@jmencak: new pull request created: #1080

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1061#issuecomment-2158229769): >/cherry-pick release-4.16 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.