search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

[release-4.15] OCPBUGS-33929: Negative net interface name fix #1066

Closed MarSik closed 5 months ago

MarSik commented 6 months ago

Negative net interface name does not reduce queues

This is a semi-automated cherry-pick of #973 and replaces #1062

The internal regular expression has duplicated exclamation mark that breaks the pattern.

openshift-ci-robot commented 6 months ago

@MarSik: This pull request references Jira Issue OCPBUGS-33929, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-30111](https://issues.redhat.com//browse/OCPBUGS-30111) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-30111](https://issues.redhat.com//browse/OCPBUGS-30111) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0 * bug has dependents

Requesting review from QA contact: /cc @gsr-shanks

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1066): >Negative net interface name does not reduce queues > >This is a semi-automated cherry-pick of #973 and replaces #1062 > >The internal regular expression has duplicated exclamation mark that breaks the pattern. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.15/OWNERS)~~ [MarSik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 5 months ago

/retest

openshift-ci[bot] commented 5 months ago

@MarSik: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yanirq commented 5 months ago

/lgtm

MarSik commented 5 months ago

/label backport-risk-assessed

mrniranjan commented 5 months ago

/label cherry-pick-approved

MarSik commented 5 months ago

/cherry-pick release-4.14

openshift-cherrypick-robot commented 5 months ago

@MarSik: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1066#issuecomment-2152350941): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 5 months ago

@MarSik: Jira Issue OCPBUGS-33929: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33929 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1066): >Negative net interface name does not reduce queues > >This is a semi-automated cherry-pick of #973 and replaces #1062 > >The internal regular expression has duplicated exclamation mark that breaks the pattern. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 5 months ago

@MarSik: new pull request created: #1074

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1066#issuecomment-2152350941): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.15.0-202406061440.p0.gd736c81.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.

openshift-merge-robot commented 5 months ago

Fix included in accepted release 4.15.0-0.nightly-2024-06-10-105316