Closed rbaturov closed 3 weeks ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rbaturov Once this PR has been reviewed and has the lgtm label, please assign kpouget for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@rbaturov: This pull request explicitly references no jira issue.
conceptually OK, but let's make sure to have good e2e coverage because we hit issues in the past when doing something similar on NROP. Most notably, the MG collections halts mid way if we try to collect objects which don't exist in the cluster. This has to be dealt with.
@rbaturov: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-gcp-pao-updating-profile | c8941460e8a04287becb120f6d068363c60a2c58 | link | true | /test e2e-gcp-pao-updating-profile |
ci/prow/e2e-hypershift | c8941460e8a04287becb120f6d068363c60a2c58 | link | true | /test e2e-hypershift |
ci/prow/e2e-hypershift-pao | c8941460e8a04287becb120f6d068363c60a2c58 | link | true | /test e2e-hypershift-pao |
ci/prow/e2e-aws-ovn | c8941460e8a04287becb120f6d068363c60a2c58 | link | true | /test e2e-aws-ovn |
Full PR test history. Your PR dashboard.
conceptually OK, but let's make sure to have good e2e coverage because we hit issues in the past when doing something similar on NROP. Most notably, the MG collections halts mid way if we try to collect objects which don't exist in the cluster. This has to be dealt with.
Meaning we should verify whether we have a test under the 6_mustgather_testing
that will raise an error if what you described is occurring?
edit: if the must-gather will halt mid-way, the entire suite will fail, don't it?
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
PR needs rebase.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen
.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Exclude this issue from closing again by commenting /lifecycle frozen
.
/close
@openshift-bot: Closed this PR.
Add relatedObjects support to better integrate with must-gather
relatedObjects is a list of objects that are "interesting" or related to this operator. must-gather uses this field to collect data from these object when data from the operator is collected.
Note: this is a cherry-pick from this abandoned PR