openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: PPC: Add relatedObjects status field #1067

Closed rbaturov closed 3 weeks ago

rbaturov commented 6 months ago

Add relatedObjects support to better integrate with must-gather

relatedObjects is a list of objects that are "interesting" or related to this operator. must-gather uses this field to collect data from these object when data from the operator is collected.

Note: this is a cherry-pick from this abandoned PR

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbaturov Once this PR has been reviewed and has the lgtm label, please assign kpouget for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 6 months ago

@rbaturov: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1067): >Add relatedObjects support to better integrate with must-gather > >relatedObjects is a list of objects that are "interesting" or related to this operator. >must-gather uses this field to collect data from these object when data from the operator is collected. > >**Note**: this is a cherry-pick from this [abandoned PR](https://github.com/openshift/cluster-node-tuning-operator/pull/819) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ffromani commented 6 months ago

conceptually OK, but let's make sure to have good e2e coverage because we hit issues in the past when doing something similar on NROP. Most notably, the MG collections halts mid way if we try to collect objects which don't exist in the cluster. This has to be dealt with.

openshift-ci[bot] commented 5 months ago

@rbaturov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-pao-updating-profile c8941460e8a04287becb120f6d068363c60a2c58 link true /test e2e-gcp-pao-updating-profile
ci/prow/e2e-hypershift c8941460e8a04287becb120f6d068363c60a2c58 link true /test e2e-hypershift
ci/prow/e2e-hypershift-pao c8941460e8a04287becb120f6d068363c60a2c58 link true /test e2e-hypershift-pao
ci/prow/e2e-aws-ovn c8941460e8a04287becb120f6d068363c60a2c58 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rbaturov commented 5 months ago

conceptually OK, but let's make sure to have good e2e coverage because we hit issues in the past when doing something similar on NROP. Most notably, the MG collections halts mid way if we try to collect objects which don't exist in the cluster. This has to be dealt with.

Meaning we should verify whether we have a test under the 6_mustgather_testing that will raise an error if what you described is occurring?

edit: if the must-gather will halt mid-way, the entire suite will fail, don't it?

openshift-bot commented 2 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-merge-robot commented 2 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 weeks ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 3 weeks ago

@openshift-bot: Closed this PR.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1067#issuecomment-2439897688): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.