search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

CNF-10616: e2e: Added hwlatdetect default window size #926

Closed SargunNarula closed 5 months ago

SargunNarula commented 10 months ago

The hwlatdetect tests were executed without a default window size. We need to make sure the window size is always consistent and same.

openshift-ci[bot] commented 10 months ago

Hi @SargunNarula. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shajmakh commented 10 months ago

/lgtm cancel label added by mistake.

shajmakh commented 10 months ago

/ok-to-test

shajmakh commented 9 months ago

/lgtm thanks for this

SargunNarula commented 9 months ago

/test e2e-aws-ovn /test e2e-aws-ovn-techpreview

shajmakh commented 9 months ago

/retitle CNF-10616: e2e: Added hwlatdetect default window size

openshift-ci-robot commented 9 months ago

@SargunNarula: This pull request references CNF-10616 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/926): >The hwlatdetect tests were executed without a default window size. We need to make sure the window size is always consistent and same. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ffromani commented 9 months ago

/approve

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, SargunNarula, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD f68b3a245b18dcd240d40139523a1e789f039ca2 and 2 for PR HEAD b3f1ae64fbe764d7a4ee7103c7e96c42c5fb3e9e in total

openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD 836b32796939a708c4fc4db56e02ab9fe09db5df and 1 for PR HEAD b3f1ae64fbe764d7a4ee7103c7e96c42c5fb3e9e in total

openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD fd8ea4edcf27b549d0360a68adf8802b845216ba and 0 for PR HEAD b3f1ae64fbe764d7a4ee7103c7e96c42c5fb3e9e in total

openshift-ci-robot commented 9 months ago

/hold

Revision b3f1ae64fbe764d7a4ee7103c7e96c42c5fb3e9e was retested 3 times: holding

shajmakh commented 8 months ago

/retest

shajmakh commented 7 months ago

@SargunNarula I think this needs a rebase, may you handle that?

SargunNarula commented 5 months ago

/retest

shajmakh commented 5 months ago

/retest

Tal-or commented 5 months ago

/lgtm /hold cancel

Tal-or commented 5 months ago

/lgtm

ffromani commented 5 months ago

/override e2e-hypershift /override e2e-hypershift-pao

these lanes passed previously, and this is a trivial test-only fix which was in the workins since January. I'll watch it post-merge and will fix any (unlikely) breakage caused.

openshift-ci[bot] commented 5 months ago

@ffromani: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/926#issuecomment-2137737518): >/override e2e-hypershift >/override e2e-hypershift-pao > >these lanes passed previously, and this is a trivial test-only fix which was in the workins since January. >I'll watch it post-merge and will fix any (unlikely) breakage caused. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD bc1d841203382e2071652edccba80541f50d3b83 and 2 for PR HEAD bc8099921cff3f80e83d4da043def8aeebbf7822 in total

openshift-ci[bot] commented 5 months ago

@SargunNarula: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202405300213.p0.g345d258.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.