search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

[release-4.15] OCPBUGS-29936: Add support to inject owner-ref argument to render command #966

Closed openshift-cherrypick-robot closed 8 months ago

openshift-cherrypick-robot commented 9 months ago

This is an automated cherry-pick of #960

/assign rbaturov

MarSik commented 9 months ago

/label backport-risk-assessed /approve /lgtm

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.15/OWNERS)~~ [MarSik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rbaturov commented 9 months ago

/retest required

openshift-ci[bot] commented 9 months ago

@rbaturov: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/966#issuecomment-1958807166): >/retest required Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rbaturov commented 9 months ago

/test e2e-aws-ovn-techpreview e2e-aws-ovn

rbaturov commented 9 months ago

/test e2e-aws-ovn-techpreview

rbaturov commented 9 months ago

/retitle [release-4.15] [OCPBUGS-29936]: Add support to inject owner-ref argument to render command

yanirq commented 9 months ago

/retitle [release-4.15] OCPBUGS-29936: Add support to inject owner-ref argument to render command

openshift-ci-robot commented 9 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29936, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/966): >This is an automated cherry-pick of #960 > >/assign rbaturov Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanirq commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@yanirq: This pull request references Jira Issue OCPBUGS-29936, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-29934](https://issues.redhat.com//browse/OCPBUGS-29934) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-29934](https://issues.redhat.com//browse/OCPBUGS-29934) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/966#issuecomment-1964428677): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanirq commented 8 months ago

/retest-required

openshift-ci[bot] commented 8 months ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
shajmakh commented 8 months ago

/label cherry-pick-approved

openshift-ci-robot commented 8 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29936: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29936 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/966): >This is an automated cherry-pick of #960 > >/assign rbaturov Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rbaturov commented 8 months ago

/cherry-pick release-4.14

openshift-cherrypick-robot commented 8 months ago

@rbaturov: #966 failed to apply on top of branch "release-4.14":

Applying: Add support to inject owner-ref argument to render command
Using index info to reconstruct a base tree...
M   hack/render-sync.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/render-sync.sh
CONFLICT (content): Merge conflict in hack/render-sync.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add support to inject owner-ref argument to render command
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/966#issuecomment-1969029406): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.15.0-202402281608.p0.geae91e9.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.