search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

Jira PSAP-1288: NTO operand cleanup #970

Closed jmencak closed 9 months ago

jmencak commented 9 months ago

In preparation for running TuneD prior to kubelet, make things simpler and cleaner.

Notable changes:

openshift-ci[bot] commented 9 months ago

@jmencak: GitHub didn't allow me to request PR reviews from the following users: jmencak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/970): >In preparation for running TuneD prior to kubelet, make things simpler and cleaner. > >Notable changes: > * Even though there is currently no namespace collision with TuneD using in/var/lib/tuned, change this path to /var/lib/ocp-tuned > * Remove bin/run. While this means a little code duplication across Containerfiles, we no longer need to do anything special at run time. This should make things easier for the future. > * Do not inherit --enable-leader-election and --version NTO flags as they are not handled by subcommands anyway (yet) > * Remove openshift-tuned binary and use NTO subcommand instead. > * /var/lib/tuned/profiles-data is no longer used, remove it. > * Remove openshift-tuned PID file code. It is no longer used. > * Clean up after PR844 > >/cc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 9 months ago

@jmencak: This pull request references PSAP-1288 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/970): >In preparation for running `TuneD` prior to kubelet, make things simpler and cleaner. > >Notable changes: > * Even though there is currently no namespace collision with `TuneD` using in/var/lib/tuned, change this path to /var/lib/ocp-tuned > * Remove bin/run. While this means a little code duplication across Containerfiles, we no longer need to do anything special at run time. This should make things easier for the future. > * Do not inherit `--enable-leader-election` and `--version` NTO flags as they are not handled by subcommands anyway (yet) > * Remove openshift-tuned binary and use NTO subcommand instead. > * /var/lib/tuned/profiles-data is no longer used, remove it. > * Remove openshift-tuned PID file code. It is no longer used. > * Clean up after PR844 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 9 months ago

/cc @yanirq @marsik @Tal-or

openshift-ci-robot commented 9 months ago

@jmencak: This pull request references PSAP-1288 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/970): >In preparation for running `TuneD` prior to kubelet, make things simpler and cleaner. > >Notable changes: > * Even though there is currently no namespace collision with `TuneD` using in /var/lib/tuned, change this path to /var/lib/ocp-tuned > * Remove bin/run. While this means a little code duplication across Containerfiles, we no longer need to do anything special at run time. This should make things easier for the future. > * Do not inherit `--enable-leader-election` and `--version` NTO flags as they are not handled by subcommands anyway (yet) > * Remove openshift-tuned binary and use NTO subcommand instead. > * /var/lib/tuned/profiles-data is no longer used, remove it. > * Remove openshift-tuned PID file code. It is no longer used. > * Clean up after PR844 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 9 months ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yanirq commented 9 months ago

Until when do we need to maintain Dockerfile.rhel8 ?

jmencak commented 9 months ago

Until when do we need to maintain Dockerfile.rhel8 ?

As long as 4.12 is supported, because it is the last one, where NTO uses RHEL8 as the base. I'd say we can safely drop it after January 17, 2025.

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik,jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 9 months ago

This looks good to me. I will let Yanir issue the last lgtm as he had a question.

lgtm as well (although the bot already has interpreted the comment as lgtm)

MarSik commented 9 months ago

Heh, I thought you have to use the command form of lgtm. The bot is too smart it seems :)

openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202402271510.p0.g11ca6b4.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.