search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: e2e: perf-prof: increase logging for debugging #974

Closed shajmakh closed 8 months ago

shajmakh commented 8 months ago

One of the tests is failing in u/s and printing out the pod events is not enough for debugging. Add another condition to skip the test if the requested cpus is greater than what the node can provide; and log a bit more info about the pod to be created.

jlojosnegros commented 8 months ago

/lgtm

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 8 months ago

/retest-required

yanirq commented 8 months ago

/retest-required

yanirq commented 8 months ago

@shajmakh if this need a cherry pick - please open a bug and add to the PR title (otherwise add the NO-JIRA title)

ffromani commented 8 months ago

/retest-required

shajmakh commented 8 months ago

/retitle NO-JIRA: e2e: perf-prof: increase logging for debugging

openshift-ci-robot commented 8 months ago

@shajmakh: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/974): >One of the tests is failing in u/s and printing out the pod events is not enough for debugging. >Add another condition to skip the test if the requested cpus is greater than what the node can provide; and log a bit more info about the pod to be created. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD 28bebe3a9511a4f8234b81fef7d501ab415cd9e2 and 2 for PR HEAD 46e0e2cfb24a7723e988af39164c19b5fe7b2fd9 in total

openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD 829b837e70b428dd076af4f9f44bfeff2cfce697 and 1 for PR HEAD 46e0e2cfb24a7723e988af39164c19b5fe7b2fd9 in total

openshift-ci[bot] commented 8 months ago

@shajmakh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202403061047.p0.ge4995df.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.