search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

[release-4.15] OCPBUGS-30152: fix rendering extra ctrcfgs #975

Closed vitus133 closed 6 months ago

vitus133 commented 8 months ago

This is a manual cherry-pick of PR #972 Fix bootstrap error of "more than one ContainerRuntimeConfig found that matches MCP labels" when an additional ContainerRuntimeConfig is provided by user. /cc @yanirq @MarSik

openshift-ci-robot commented 8 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-30152, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/975): >This is a manual cherry-pick of PR #972 >Fix bootstrap error of "more than one ContainerRuntimeConfig found that matches MCP labels" when an additional ContainerRuntimeConfig is provided by user. >/cc @yanirq @MarSik > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vitus133 commented 8 months ago

/jira refresh

openshift-ci-robot commented 8 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-30152, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/975#issuecomment-1975153793): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanirq commented 8 months ago

/retitle [release-4.15] OCPBUGS-30152: fix rendering extra ctrcfgs

yanirq commented 8 months ago

@vitus133 Can you please add an entry to our sync code (hack/render-sync.sh) that will update the expected output when needed?

see example: https://github.com/openshift/cluster-node-tuning-operator/blob/28bebe3a9511a4f8234b81fef7d501ab415cd9e2/hack/render-sync.sh#L43

We can align master branch separately but lets have the cherry picks include this already

vitus133 commented 8 months ago

@vitus133 Can you please add an entry to our sync code (hack/render-sync.sh) that will update the expected output when needed?

done

MarSik commented 8 months ago

/label backport-risk-assessed

yanirq commented 8 months ago

/approve

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vitus133, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.15/OWNERS)~~ [yanirq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 8 months ago

/lgtm

yanirq commented 8 months ago

/cc @shajmakh @mrniranjan

yanirq commented 8 months ago

/retest

yanirq commented 8 months ago

/jira refresh

openshift-ci-robot commented 8 months ago

@yanirq: This pull request references Jira Issue OCPBUGS-30152, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/975#issuecomment-1988826809): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 8 months ago

@mrniranjan: The label(s) /label cherry-pick-approved, cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/975#issuecomment-1990633846): >/label cherry-pick-approved, Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mrniranjan commented 8 months ago

/label cherry-pick-approved

yanirq commented 8 months ago

/test e2e-hypershift

yanirq commented 8 months ago

/retest-required

yanirq commented 6 months ago

@vitus133 please rebase on top of the latest

openshift-ci[bot] commented 6 months ago

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yanirq commented 6 months ago

/lgtm

vitus133 commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-30152, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/975#issuecomment-2095523744): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vitus133 commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-30152, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-29641](https://issues.redhat.com//browse/OCPBUGS-29641) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-29641](https://issues.redhat.com//browse/OCPBUGS-29641) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0 * bug has dependents

Requesting review from QA contact: /cc @mrniranjan

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/975#issuecomment-2095537107): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@vitus133: Jira Issue OCPBUGS-30152: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30152 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/975): >This is a manual cherry-pick of PR #972 >Fix bootstrap error of "more than one ContainerRuntimeConfig found that matches MCP labels" when an additional ContainerRuntimeConfig is provided by user. >/cc @yanirq @MarSik > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.15.0-202405061007.p0.gdbffff2.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.