openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-30432: CVE-2024-24786: protobuf #985

Closed jmencak closed 8 months ago

jmencak commented 8 months ago

This PR addresses CVE-2024-24786 by bumping:

openshift-ci-robot commented 8 months ago

@jmencak: This pull request references Jira Issue OCPBUGS-30432, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/985): >This PR addresses CVE-2024-24786 by bumping google.golang.org/protobuf to v1.33.0. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 8 months ago

/retest

jmencak commented 8 months ago

/retest

jmencak commented 8 months ago

/retest

ffromani commented 8 months ago

/lgtm

openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD f9c912bde967f7299c3c1aa24e48e45febcecd94 and 2 for PR HEAD 4cdd79c2ac70ce93c321a857a5f3695d11c726d8 in total

openshift-ci-robot commented 8 months ago

@jmencak: This pull request references Jira Issue OCPBUGS-30432, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/985): > This PR addresses CVE-2024-24786 by bumping: > * google.golang.org/protobuf to v1.33.0 > * github.com/golang/protobuf to v1.5.4 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ffromani commented 8 months ago

/lgtm /hold holding to let other reviewes chime in

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik,jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jmencak commented 8 months ago

Thank you for the reviews.

/hold cancel

openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD f9c912bde967f7299c3c1aa24e48e45febcecd94 and 2 for PR HEAD 91eb1aa2caa936b8a58b8ed0954ca463bc330652 in total

jmencak commented 8 months ago

/retest

jmencak commented 8 months ago

/retest

openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD 4548e76826926664c79c0c2c7bd11023044d917e and 1 for PR HEAD 91eb1aa2caa936b8a58b8ed0954ca463bc330652 in total

openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD 3621ef7ba7ea2d1c591970d203f7ef0a2b8c00ac and 0 for PR HEAD 91eb1aa2caa936b8a58b8ed0954ca463bc330652 in total

openshift-ci-robot commented 8 months ago

/hold

Revision 91eb1aa2caa936b8a58b8ed0954ca463bc330652 was retested 3 times: holding

jmencak commented 8 months ago

/hold cancel /retest

openshift-ci[bot] commented 8 months ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 8 months ago

@jmencak: Jira Issue OCPBUGS-30432: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30432 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/985): > This PR addresses CVE-2024-24786 by bumping: > * google.golang.org/protobuf to v1.33.0 > * github.com/golang/protobuf to v1.5.4 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202403141746.p0.geb35a4e.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.