search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-30812: Ignore scheduler plugin IRQs when globally enabled #987

Closed yanirq closed 8 months ago

yanirq commented 8 months ago

Disable irq affinity setting by scheduler plugin ONLY when GloballyDisableIrqLoadBalancing=false (default)

openshift-ci-robot commented 8 months ago

@yanirq: This pull request references Jira Issue OCPBUGS-26400, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/987): >Disable irq affinity setting by scheduler plugin ONLY when GloballyDisableIrqLoadBalancing=false (default) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanirq commented 8 months ago

/jira refresh

openshift-ci-robot commented 8 months ago

@yanirq: This pull request references Jira Issue OCPBUGS-26400, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @shajmakh

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/987#issuecomment-1991577139): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ffromani commented 8 months ago

/lgtm

the e2e-no-cluster failure is legit, you probably need to run make render-sync

ffromani commented 8 months ago

/lgtm

yanirq commented 8 months ago

/lgtm

the e2e-no-cluster failure is legit, you probably need to run make render-sync

The reason for the missing sync is https://github.com/openshift/cluster-node-tuning-operator/pull/980 . until its merged I added the missing changes manually.

yanirq commented 8 months ago

/cc @MarSik

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik,yanirq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MarSik commented 8 months ago

/retitle OCPBUGS-30812: Ignore scheduler plugin IRQs when globally enabled

openshift-ci-robot commented 8 months ago

@yanirq: This pull request references Jira Issue OCPBUGS-30812, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/987): >Disable irq affinity setting by scheduler plugin ONLY when GloballyDisableIrqLoadBalancing=false (default) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
MarSik commented 8 months ago

/jira refresh

openshift-ci-robot commented 8 months ago

@MarSik: This pull request references Jira Issue OCPBUGS-30812, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @gsr-shanks

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/987#issuecomment-1993969346): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD f9c912bde967f7299c3c1aa24e48e45febcecd94 and 2 for PR HEAD 8a965c72834d8c043cc10aef74eb54f30f90cdcd in total

openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD 4548e76826926664c79c0c2c7bd11023044d917e and 1 for PR HEAD 8a965c72834d8c043cc10aef74eb54f30f90cdcd in total

mrniranjan commented 8 months ago

/test e2e-gcp-pao-updating-profile

yanirq commented 8 months ago

/retest

openshift-ci[bot] commented 8 months ago

@yanirq: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 8 months ago

@yanirq: Jira Issue OCPBUGS-30812: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30812 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/987): >Disable irq affinity setting by scheduler plugin ONLY when GloballyDisableIrqLoadBalancing=false (default) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.