openshift / cluster-version-operator

Apache License 2.0
84 stars 191 forks source link

no-jira: TestSetCapabilities: use KnownClusterVersionCapabilities for known keys instead of picking DefaultCapabilitySet #1073

Closed ingvagabund closed 4 months ago

ingvagabund commented 4 months ago

KnownClusterVersionCapabilities is the referential list of known capabilities. ClusterVersionCapabilitySetCurrent/DefaultCapabilitySet can change in time. As in https://github.com/openshift/api/pull/1954.

To unblock https://github.com/openshift/cluster-version-operator/pull/1066.

openshift-ci-robot commented 4 months ago

@ingvagabund: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-version-operator/pull/1073): >KnownClusterVersionCapabilities is the referential list of known capabilities. ClusterVersionCapabilitySetCurrent/DefaultCapabilitySet can change in time. As in https://github.com/openshift/api/pull/1954. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-version-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ingvagabund commented 4 months ago

/retest-required

ingvagabund commented 4 months ago

/retest-required

ingvagabund commented 4 months ago

/retest-required

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-version-operator/blob/master/OWNERS)~~ [petr-muller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
petr-muller commented 4 months ago

/label no-qe

Unit test change only, no pre-merge testing needed

ingvagabund commented 4 months ago

/retest-required

openshift-ci-robot commented 4 months ago

/retest-required

Remaining retests: 0 against base HEAD 8244b525da0ceab58e1098fb5680f94c582d4fbd and 2 for PR HEAD 78fade90c0bcfd9ff54ac5121ce881212ec7bdf3 in total

openshift-ci[bot] commented 4 months ago

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-version-operator This PR has been included in build cluster-version-operator-container-v4.17.0-202407241715.p0.g7b989b2.assembly.stream.el9. All builds following this will include this PR.