search

openshift / cluster-version-operator

Apache License 2.0
84 stars 191 forks source link

OTA-1269: USC: Add `DevPreviewNoUpgrade`-gated manifests #1107

Open petr-muller opened 2 weeks ago

petr-muller commented 2 weeks ago

Squashed review commits:

USC: Do not tolerate taints

The original Deployment was copied from CVO which contained a bunch of strong tolerations. It does not seem USC needs to be this robust against node conditions and can be easily evicted if necessary.

https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#taints-and-tolerations

USC: Use openshift-user-critical priority class

The original USC deployment was copied from CVO which is obviously very important component and should be protected from OOM kills and preemption but USC does not seem to need it.

https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#priority-classes

If it is fine for your operator/operand to be preempted by user-workload and OOMKilled use openshift-user-critical priority class

openshift-ci-robot commented 2 weeks ago

@petr-muller: This pull request references OTA-1269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-version-operator/pull/1107): >- Namespace >- ServiceAccount >- Role that allows read, watch & update ConfigMaps (+binding) >- ClusterRole that allows read & watch ConfigVersions (+rolebinding) >- Deployment > >Squashed review commits: > >USC: Do not tolerate taints > >The original Deployment was copied from CVO which contained a bunch of >strong tolerations. It does not seem USC needs to be this robust against >node conditions and can be easily evicted if necessary. > >https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#taints-and-tolerations > >USC: Use `openshift-user-critical` priority class > >The original USC deployment was copied from CVO which is obviously very >important component and should be protected from OOM kills and preemption >but USC does not seem to need it. > >https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#priority-classes > >> If it is fine for your operator/operand to be preempted by user-workload and OOMKilled use openshift-user-critical priority class > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-version-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-version-operator/blob/master/OWNERS)~~ [petr-muller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 weeks ago

@petr-muller: This pull request references OTA-1269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-version-operator/pull/1107): >- [ ] Builds on: https://github.com/openshift/cluster-version-operator/pull/1091 >- [ ] Blocked by: https://github.com/openshift/hypershift/pull/5093 (fails hypershift without that change) > >--- > >- Namespace >- ServiceAccount >- Role that allows read, watch & update ConfigMaps (+binding) >- ClusterRole that allows read & watch ConfigVersions (+rolebinding) >- Deployment > >Squashed review commits: > >USC: Do not tolerate taints > >The original Deployment was copied from CVO which contained a bunch of >strong tolerations. It does not seem USC needs to be this robust against >node conditions and can be easily evicted if necessary. > >https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#taints-and-tolerations > >USC: Use `openshift-user-critical` priority class > >The original USC deployment was copied from CVO which is obviously very >important component and should be protected from OOM kills and preemption >but USC does not seem to need it. > >https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#priority-classes > >> If it is fine for your operator/operand to be preempted by user-workload and OOMKilled use openshift-user-critical priority class > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-version-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@petr-muller: This pull request references OTA-1269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-version-operator/pull/1107): >- [x] Builds on: https://github.com/openshift/cluster-version-operator/pull/1091 >- [ ] Blocked by: https://github.com/openshift/hypershift/pull/5093 (fails hypershift without that change) > >--- > >- Namespace >- ServiceAccount >- Role that allows read, watch & update ConfigMaps (+binding) >- ClusterRole that allows read & watch ConfigVersions (+rolebinding) >- Deployment > >Squashed review commits: > >USC: Do not tolerate taints > >The original Deployment was copied from CVO which contained a bunch of >strong tolerations. It does not seem USC needs to be this robust against >node conditions and can be easily evicted if necessary. > >https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#taints-and-tolerations > >USC: Use `openshift-user-critical` priority class > >The original USC deployment was copied from CVO which is obviously very >important component and should be protected from OOM kills and preemption >but USC does not seem to need it. > >https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#priority-classes > >> If it is fine for your operator/operand to be preempted by user-workload and OOMKilled use openshift-user-critical priority class > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-version-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
petr-muller commented 2 weeks ago

/hold

Breaks HyperShift for now

hongkailiu commented 2 weeks ago

/test e2e-agnostic-ovn-upgrade-out-of-change

openshift-ci[bot] commented 2 days ago

@petr-muller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-conformance cbdaed59b3d63ebf08f234404d051fa847c4a230 link true /test e2e-hypershift-conformance
ci/prow/e2e-aws-ovn-techpreview cbdaed59b3d63ebf08f234404d051fa847c4a230 link true /test e2e-aws-ovn-techpreview
ci/prow/okd-scos-e2e-aws-ovn cbdaed59b3d63ebf08f234404d051fa847c4a230 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-hypershift cbdaed59b3d63ebf08f234404d051fa847c4a230 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).