search

openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
22 stars 33 forks source link

OCPBUGS-3630: deployment: enforce recreate strategy to avoid conflicts during upgrades #185

Closed alebedev87 closed 9 months ago

alebedev87 commented 1 year ago

As per the upstream update: https://github.com/kubernetes-sigs/external-dns/pull/2772. ExternalDNS is currently unable of handling multiple parallel instances (no leader election implemented). This may result into split brain situation during the rolling upgrades.

openshift-ci-robot commented 1 year ago

@alebedev87: This pull request references Jira Issue OCPBUGS-3630, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.0) matches configured target version for branch (4.13.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/external-dns-operator/pull/185): >As per the upstream update: https://github.com/kubernetes-sigs/external-dns/pull/2772. ExternalDNS is currently unable of handling multiple parallel instances (no leader election implemented). This may result into split brain situation during the rolling upgrades. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
alebedev87 commented 1 year ago

Azure cluster install failure.

/retest

lihongan commented 1 year ago

/label qe-approved

candita commented 1 year ago

/assign

candita commented 1 year ago

On hold until comments addressed /hold

alebedev87 commented 1 year ago

Cluster installation failed.

/test e2e-infoblox-operator

alebedev87 commented 1 year ago 
Back-off pulling image "registry.redhat.io/redhat/redhat-marketplace-index:v4.12"

One of the OLM catalog images is missing, again...

/retest

alebedev87 commented 1 year ago

Cluster installation failed.

/test e2e-infoblox-operator

openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

alebedev87 commented 1 year ago

/remove-lifecycle stale

openshift-bot commented 10 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

alebedev87 commented 10 months ago

/remove-lifecycle stale

candita commented 9 months ago

/unhold /lgtm

openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD 5e964d7709d9af90cc9ce0b6a983a54af4bc1acf and 2 for PR HEAD d8e0462d71ecb2d5fc30e45cc9d86e1c082f8d0d in total

alebedev87 commented 9 months ago

Rebased from main, the test for SharedVPC support had to be adopted.

candita commented 9 months ago

/retest-required

openshift-ci[bot] commented 9 months ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
candita commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@candita: This pull request references Jira Issue OCPBUGS-3630, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/external-dns-operator/pull/185#issuecomment-1737635845): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
candita commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@candita: This pull request references Jira Issue OCPBUGS-3630, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/external-dns-operator/pull/185#issuecomment-1737638677): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
candita commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@candita: This pull request references Jira Issue OCPBUGS-3630, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @lihongan

In response to [this](https://github.com/openshift/external-dns-operator/pull/185#issuecomment-1737641466): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
candita commented 9 months ago

/lgtm /approve

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [candita] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 9 months ago

@alebedev87: Jira Issue OCPBUGS-3630: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3630 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/external-dns-operator/pull/185): >As per the upstream update: https://github.com/kubernetes-sigs/external-dns/pull/2772. ExternalDNS is currently unable of handling multiple parallel instances (no leader election implemented). This may result into split brain situation during the rolling upgrades. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.