search

openshift / file-integrity-operator

Operator providing OpenShift cluster node file integrity checking
Apache License 2.0
31 stars 27 forks source link

Only set node selectors for OpenShift deployments #540

Closed rhmdnd closed 2 months ago

rhmdnd commented 2 months ago

By default, the File Integrity Operator would set node selectors and taints that would only allow it to schedule on master nodes. While this is fine for OpenShift environments, some additional environments we test on, like Red Hat OpenShift on AWS (ROSA), don't provide master nodes at all.

To accomodate this in our testing and tooling, this commit removes the node selector and taint from the default bundle, and moves it into an OpenShift-specific bundle where it will still get used for OpenShift deploy paths and bundles.

This will be more useful in a future patch that implements support for running File Integrity Operator end-to-end testing on ROSA HCP, which only provides worker nodes and not master nodes.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/file-integrity-operator/blob/master/OWNERS)~~ [rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws a991252ebe6c0ee5af976b13d8a3d59b428ad6ab link true /test e2e-aws
ci/prow/e2e-bundle-aws a991252ebe6c0ee5af976b13d8a3d59b428ad6ab link true /test e2e-bundle-aws
ci/prow/e2e-bundle-aws-upgrade a991252ebe6c0ee5af976b13d8a3d59b428ad6ab link true /test e2e-bundle-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rhmdnd commented 2 months ago

Debugging the e2e failures in https://github.com/openshift/file-integrity-operator/pull/541

rhmdnd commented 2 months ago

This was already incorporated into https://github.com/openshift/file-integrity-operator/pull/539