search

openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

OCPBUGS-43724: Fix Load balancer IP setup #9144

Open rna-afk opened 1 month ago

rna-afk commented 1 month ago

Fixing the issue where the load balancer IP was not set in the range of the machine network CIDRs by setting it to the first IP in the CIDR range.

Also extending this logic to non-existing vnet installs since the problem can happen even during normal installs.

openshift-ci-robot commented 1 month ago

@rna-afk: This pull request references Jira Issue OCPBUGS-43724, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/installer/pull/9144): >Fixing the issue where the load balancer IP was not set in the range of the machine network CIDRs by setting it to the first IP in the CIDR range. > >Also extending this logic to non-existing vnet installs since the problem can happen even during normal installs. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from rna-afk. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/asset/manifests/azure/OWNERS](https://github.com/openshift/installer/blob/master/pkg/asset/manifests/azure/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rna-afk commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@rna-afk: This pull request references Jira Issue OCPBUGS-43724, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/installer/pull/9144#issuecomment-2441971574): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rna-afk commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@rna-afk: This pull request references Jira Issue OCPBUGS-43724, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jinyunma

In response to [this](https://github.com/openshift/installer/pull/9144#issuecomment-2441977546): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rna-afk commented 4 weeks ago

/retest-required

rna-afk commented 3 weeks ago

/retest

openshift-ci[bot] commented 2 weeks ago

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn d34d00be506cef8e5a95959c227086571bc86c9a link true /test e2e-azure-ovn
ci/prow/azure-ovn-marketplace-images d34d00be506cef8e5a95959c227086571bc86c9a link false /test azure-ovn-marketplace-images
ci/prow/e2e-azurestack d34d00be506cef8e5a95959c227086571bc86c9a link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).