search

openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

OCPBUGS-30292: If agent proxy defined, add MachineNetwork to noProxy #9153

Closed bfournie closed 2 weeks ago

bfournie commented 1 month ago

If proxy is defined in install-config, add the MachineNetwork that contains the RendezvousIP to the noproxy field in the generated manifests to ensure the Rendezvous host can be accessed.

This is an additional fix beyond https://github.com/openshift/installer/pull/9083 as it was found that when just setting the IP in 10-default-env.conf it did not get passed to the assisted-installer when it was started.

openshift-ci-robot commented 1 month ago

@bfournie: This pull request references Jira Issue OCPBUGS-30292, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zniu1011

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/installer/pull/9153): >If proxy is defined in install-config, add the RendezvousIP to the noproxy field in the generated manifests to ensure the Rendezvous host can be accessed. > >This is an additional fix beyond https://github.com/openshift/installer/pull/9083 as it was found that when just setting the IP in 10-default-env.conf it did not get passed to the assisted-installer when it was started. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
bfournie commented 1 month ago

/cc @rwsu @zaneb @andfasano

pawanpinjarkar commented 3 weeks ago

/lgtm

bfournie commented 3 weeks ago

/test e2e-agent-ha-dualstack

zaneb commented 3 weeks ago

Does this mean that we had a bigger problem, that the user's proxy settings were never passed on to the cluster??

bfournie commented 3 weeks ago

Does this mean that we had a bigger problem, that the user's proxy settings were never passed on to the cluster??

No, the proxy settings were passed fine to the cluster and to the assisted-installer. Its just that updating the noProxy directly in 10_default.conf.env did not forward the updated noproxy to the assisted installer container.

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[cmd/openshift-install/testdata/agent/OWNERS](https://github.com/openshift/installer/blob/master/cmd/openshift-install/testdata/agent/OWNERS)~~ [zaneb] - ~~[data/data/agent/OWNERS](https://github.com/openshift/installer/blob/master/data/data/agent/OWNERS)~~ [zaneb] - ~~[pkg/asset/agent/OWNERS](https://github.com/openshift/installer/blob/master/pkg/asset/agent/OWNERS)~~ [zaneb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zaneb commented 3 weeks ago

/hold cancel

openshift-ci-robot commented 3 weeks ago

@bfournie: This pull request references Jira Issue OCPBUGS-30292, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zniu1011

In response to [this](https://github.com/openshift/installer/pull/9153): >If proxy is defined in install-config, add the MachineNetwork that contains the RendezvousIP to the noproxy field in the generated manifests to ensure the Rendezvous host can be accessed. > >This is an additional fix beyond https://github.com/openshift/installer/pull/9083 as it was found that when just setting the IP in 10-default-env.conf it did not get passed to the assisted-installer when it was started. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rwsu commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rwsu commented 2 weeks ago

/lgtm

openshift-ci-robot commented 2 weeks ago

@bfournie: Jira Issue OCPBUGS-30292: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30292 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/installer/pull/9153): >If proxy is defined in install-config, add the MachineNetwork that contains the RendezvousIP to the noproxy field in the generated manifests to ensure the Rendezvous host can be accessed. > >This is an additional fix beyond https://github.com/openshift/installer/pull/9083 as it was found that when just setting the IP in 10-default-env.conf it did not get passed to the assisted-installer when it was started. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202411090336.p0.gc3e9b51.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra This PR has been included in build ose-installer-altinfra-container-v4.19.0-202411090336.p0.gc3e9b51.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer This PR has been included in build ose-baremetal-installer-container-v4.19.0-202411090336.p0.gc3e9b51.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts This PR has been included in build ose-installer-artifacts-container-v4.19.0-202411090336.p0.gc3e9b51.assembly.stream.el9. All builds following this will include this PR.