openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

MULTIARCH-5161: Power VS: Create VPEs as needed for Disconnected install #9165

Closed miyamotoh closed 1 week ago

miyamotoh commented 4 weeks ago

For Disconnected install on PowerVS, Virtual Private Endpoint Gateways (VPEs) must be created in the VPC that would be part of the infrastructure to allow traffic to the following private IBM Cloud endpoints;

Proposed code would first check if the necessary VPEs are already in place, comparing the target's CRN, and create one only when missing. Destroy logic for the below resources need to be developed (later);

mjturek commented 3 weeks ago

We also need DNSServices for disconnected (the ingress operator uses it)

miyamotoh commented 3 weeks ago

/test golint

mjturek commented 1 week ago

/retitle MULTIARCH-5161: Power VS: Create VPEs as needed for Disconnected install

openshift-ci-robot commented 1 week ago

@miyamotoh: This pull request references MULTIARCH-5161 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/installer/pull/9165): >For Disconnected install on PowerVS, Virtual Private Endpoint Gateways (VPEs) must be created in the VPC that would be part of the infrastructure to allow traffic to the following private IBM Cloud endpoints; >- IAM >- COS (in the region) >- DNS services > >Proposed code would first check if the necessary VPEs are already in place, comparing the target's CRN, and create one only when missing. >Destroy logic for the below resources need to be developed (later); >- Reserved IPs (on the subnet) >- VPEs (in the VPC) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
mjturek commented 1 week ago

/assign r4f4

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/installer/blob/master/OWNERS)~~ [r4f4] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 week ago

@miyamotoh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 8fc735142ef6543455de1361522e88a222b368da link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sadasu commented 1 week ago

/label acknowledge-critical-fixes-only

@mjturek can add the final label after review

mjturek commented 1 week ago

/lgtm