openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

NO-ISSUE: Add mresvanis to imagebased approvers #9168

Closed mresvanis closed 3 weeks ago

mresvanis commented 3 weeks ago

This change adds mresvanis to the imagebased installer approvers.

openshift-ci[bot] commented 3 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

mresvanis commented 3 weeks ago

/test all

openshift-ci-robot commented 3 weeks ago

@mresvanis: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/installer/pull/9168): >This changes adds `mresvanis` to the `imagebased` installer approvers. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
mresvanis commented 3 weeks ago

/cc @eranco74 @tsorya

tsorya commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

@mresvanis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tsorya commented 3 weeks ago

/approve

patrickdillon commented 3 weeks ago

/approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/installer/blob/master/OWNERS)~~ [patrickdillon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra This PR has been included in build ose-installer-altinfra-container-v4.18.0-202411042337.p0.gcf09e38.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer This PR has been included in build ose-baremetal-installer-container-v4.18.0-202411042337.p0.gcf09e38.assembly.stream.el9. All builds following this will include this PR.