search

openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

OCPBUGS-44171: Validate aws userTags when supplied #9171

Closed barbacbd closed 2 weeks ago

barbacbd commented 3 weeks ago

AWS User tags support white space as valid characters. User tags should be validated every time that they are supplied not only when propagateTags is True.

openshift-ci-robot commented 3 weeks ago

@barbacbd: This pull request references Jira Issue OCPBUGS-44171, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/installer/pull/9171): >** AWS User tags support white space as valid characters. >** User tags should be validated every time that they are supplied not only when propagateTags is True. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
barbacbd commented 3 weeks ago

/cc @patrickdillon @r4f4

barbacbd commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@barbacbd: This pull request references Jira Issue OCPBUGS-44171, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @gpei

In response to [this](https://github.com/openshift/installer/pull/9171#issuecomment-2455602467): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 weeks ago

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-heterogeneous 390cd0dfd800ebbd97b40c0f6952588c6cc71649 link false /test e2e-aws-ovn-heterogeneous

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sadasu commented 2 weeks ago

/approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/types/aws/OWNERS](https://github.com/openshift/installer/blob/master/pkg/types/aws/OWNERS)~~ [sadasu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 weeks ago

@barbacbd: Jira Issue OCPBUGS-44171: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44171 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/installer/pull/9171): >** AWS User tags support white space as valid characters. >** User tags should be validated every time that they are supplied not only when propagateTags is True. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra This PR has been included in build ose-installer-altinfra-container-v4.18.0-202411122008.p0.gb926ff4.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202411122008.p0.gb926ff4.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer This PR has been included in build ose-baremetal-installer-container-v4.19.0-202411122008.p0.gb926ff4.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts This PR has been included in build ose-installer-artifacts-container-v4.19.0-202411122008.p0.gb926ff4.assembly.stream.el9. All builds following this will include this PR.