search

openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

DNM: Ocpbugs 43970 with capo fixes #9174

Closed mandre closed 3 weeks ago

mandre commented 3 weeks ago

Testing CAPO bump with fix from https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2237.

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rna-afk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/installer/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 weeks ago

@mandre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-vendor 8e5beffdcac3742139aa844f02f451702a8db2f3 link true /test verify-vendor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mandre commented 3 weeks ago

This worked as expected and confirmed the CI didn't catch other bugs than the one we just fixed. /close

openshift-ci[bot] commented 3 weeks ago

@mandre: Closed this PR.

In response to [this](https://github.com/openshift/installer/pull/9174#issuecomment-2456850046): >This worked as expected and confirmed the CI didn't catch other bugs than the one we just fixed. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.