search

openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

OPRUN-3588: Add OperatorLifecycleManagerV1 capability #9196

Closed everettraven closed 1 week ago

everettraven commented 2 weeks ago

Description

Updates the InstallConfig .capabilities.additionalEnabledCapabilities to add the OperatorLifecycleManagerV1 capability.

Updated openshift/api, openshift/library-go, openshift/client-go to the latest versions to pull in the new capability

Prior ART for adding CVO capability:

everettraven commented 2 weeks ago

/hold

everettraven commented 2 weeks ago

/retest

everettraven commented 2 weeks ago

/retest

perdasilva commented 1 week ago

Add OPRUN-3588: to the PR title =D

openshift-ci-robot commented 1 week ago

@everettraven: This pull request references OPRUN-3588 which is a valid jira issue.

In response to [this](https://github.com/openshift/installer/pull/9196): >## Description >Updates the `InstallConfig` `.capabilities.additionalEnabledCapabilities` to add the `OperatorLifecycleManagerV1` capability. > >Updated openshift/api, openshift/library-go, openshift/client-go to the latest versions to pull in the new capability Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
LalatenduMohanty commented 1 week ago

@installer-team Can you please take a look. We need this PR before code branch for 4.18 happens.

openshift-ci-robot commented 1 week ago

@everettraven: This pull request references OPRUN-3588 which is a valid jira issue.

In response to [this](https://github.com/openshift/installer/pull/9196): >## Description >Updates the `InstallConfig` `.capabilities.additionalEnabledCapabilities` to add the `OperatorLifecycleManagerV1` capability. > >Updated openshift/api, openshift/library-go, openshift/client-go to the latest versions to pull in the new capability > >Prior ART for adding CVO capability: >- https://github.com/openshift/api/pull/2097 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
LalatenduMohanty commented 1 week ago

https://github.com/openshift/cluster-version-operator/pull/1108 is the PR to add the capability to CVO

openshift-ci-robot commented 1 week ago

@everettraven: This pull request references OPRUN-3588 which is a valid jira issue.

In response to [this](https://github.com/openshift/installer/pull/9196): >## Description >Updates the `InstallConfig` `.capabilities.additionalEnabledCapabilities` to add the `OperatorLifecycleManagerV1` capability. > >Updated openshift/api, openshift/library-go, openshift/client-go to the latest versions to pull in the new capability > >Prior ART for adding CVO capability: >- https://github.com/openshift/api/pull/2097 >- https://github.com/openshift/cluster-version-operator/pull/1108 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
patrickdillon commented 1 week ago

@everettraven the install config crd can be generated with

go generate ./pkg/types/installconfig.go

Can you squash the fix commit? It looks like this pr is just vendoring new dependencies and then generating the new crd, so if you want to squash everything into one commit that is fine too

everettraven commented 1 week ago

@patrickdillon I rolled the fix commit into the commit to regenerate the CRD

patrickdillon commented 1 week ago

/approve

everettraven commented 1 week ago

/hold cancel

dtfranz commented 1 week ago

/lgtm

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, patrickdillon, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/installer/blob/master/OWNERS)~~ [patrickdillon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 week ago

@everettraven: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 2abc62275b2f0361314270b3a0637039b676f075 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).