OCPBUGS-44193: Reduce Server Side Filtering of Resources

[barbacbd]

The destroy code is using server side filtering on resources. The number of resources that are filtered out (server side) are causing quota limits to be reached. Moving the filtering to the client side will limit quota max errors.

[openshift-ci-robot]

@barbacbd: This pull request references Jira Issue OCPBUGS-44193, which is valid.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jianli-wei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/installer/pull/9202): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[barbacbd]

/cc @patrickdillon

[barbacbd]

/uncc @andfasano

[patrickdillon]

/retest

[barbacbd]

/label acknowledge-critical-fixes-only

[barbacbd]

/label platform/google

[patrickdillon]

Fortunately, GCP collects quota data for what we delete, so we can compare the quota for the latest run from this PR with, say, another presubmit

Using jd to compare...

$ jd -set pr-quota.json presubmit-quota.json 
@ ["gcp",["set"],{}]
- {"amount":2,"dimensions":{"network_id":"ci-op-46zmsc2l-6a305-8rbkj-network"},"limit":"subnet_ranges_per_vpc_network","service":"compute.googleapis.com"}
- {"amount":1,"dimensions":{"region":"us-central1"},"limit":"internal_addresses","service":"compute.googleapis.com"}
+ {"amount":1,"dimensions":{"region":""},"limit":"addresses","service":"compute.googleapis.com"}
+ {"amount":40,"dimensions":{"region":"us-central1"},"limit":"disks_total_storage","service":"compute.googleapis.com"}
+ {"amount":1,"dimensions":{"region":"us-central1"},"limit":"addresses","service":"compute.googleapis.com"}
+ {"amount":2,"dimensions":{"network_id":"ci-op-23kt0cp6-6a305-sshhv-network"},"limit":"subnet_ranges_per_vpc_network","service":"compute.googleapis.com"}

The first thing that jumps out is it looks like we're leaking disks, so let's

/hold

until we can check that out.

Networks look ok, it's just diffing on the names. Not sure what's going on with addresses. We will need to look more closely.

[patrickdillon]

/approve /hold cancel The disks question is just that they're deleting different kinds of disks

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/destroy/gcp/OWNERS](https://github.com/openshift/installer/blob/master/pkg/destroy/gcp/OWNERS)~~ [patrickdillon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 545c830586292bd62196834b0d200f1759f47ee9 and 2 for PR HEAD 338e0c96f95e6be612712e26716a0af5145ba42b in total

[openshift-ci[bot]]

@barbacbd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[openshift-ci-robot]

@barbacbd: Jira Issue OCPBUGS-44193: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/installer#9169 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-44193 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/installer/pull/9202): >The destroy code is using server side filtering on resources. The number of resources that >are filtered out (server side) are causing quota limits to be reached. Moving the filtering >to the client side will limit quota max errors. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.