openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

OCPBUGS-44523: Remove unused variable from ASH arm template 06_workers.json #9204

Open jinyunma opened 2 weeks ago

jinyunma commented 2 weeks ago

The content of arm template 06_workers.json in installer repo is shown in official azure stack hub upi installation doc, variables identityName is not being used, remove it to avoid confusion from user when creating UPI cluster on azure stack hub.

openshift-ci-robot commented 2 weeks ago

@jinyunma: This pull request references Jira Issue OCPBUGS-44523, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jinyunma

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/installer/pull/9204): >The content of arm template 06_workers.json in installer repo is shown in [official azure upi installation doc](https://docs.openshift.com/container-platform/4.17/installing/installing_azure/upi/installing-azure-user-infra.html#installation-creating-azure-worker_installing-azure-user-infra), variables `identityName` is not being used, remove it to avoid confusion from user when creating UPI cluster on azure stack hub. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jinyunma.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/installer/pull/9204#issuecomment-2475313418): >@jinyunma: This pull request references [Jira Issue OCPBUGS-44523](https://issues.redhat.com//browse/OCPBUGS-44523), which is valid. The bug has been moved to the POST state. > >
3 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.18.0) matches configured target version for branch (4.18.0) >* bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jinyunma

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/installer/pull/9204): >The content of arm template 06_workers.json in installer repo is shown in [official azure upi installation doc](https://docs.openshift.com/container-platform/4.17/installing/installing_azure/upi/installing-azure-user-infra.html#installation-creating-azure-worker_installing-azure-user-infra), variables `identityName` is not being used, remove it to avoid confusion from user when creating UPI cluster on azure stack hub. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jianlinliu commented 2 weeks ago

/lgtm

openshift-ci-robot commented 2 weeks ago

@jinyunma: This pull request references Jira Issue OCPBUGS-44523, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jinyunma

In response to [this](https://github.com/openshift/installer/pull/9204): >The content of arm template 06_workers.json in installer repo is shown in [official azure stack hub upi installation doc](https://docs.openshift.com/container-platform/4.17/installing/installing_azure/upi/installing-azure-user-infra.html#installation-creating-azure-worker_installing-azure-user-infra), variables `identityName` is not being used, remove it to avoid confusion from user when creating UPI cluster on azure stack hub. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jinyunma.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/installer/pull/9204#issuecomment-2475318461): >@jinyunma: This pull request references [Jira Issue OCPBUGS-44523](https://issues.redhat.com//browse/OCPBUGS-44523), which is valid. > >
3 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.18.0) matches configured target version for branch (4.18.0) >* bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jinyunma

In response to [this](https://github.com/openshift/installer/pull/9204): >The content of arm template 06_workers.json in installer repo is shown in [official azure stack hub upi installation doc](https://docs.openshift.com/container-platform/4.17/installing/installing_azure/upi/installing-azure-user-infra.html#installation-creating-azure-worker_installing-azure-user-infra), variables `identityName` is not being used, remove it to avoid confusion from user when creating UPI cluster on azure stack hub. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

gpei commented 2 weeks ago

/test ci/prow/e2e-azurestack-upi

openshift-ci[bot] commented 2 weeks ago

@gpei: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/installer/pull/9204#issuecomment-2475376859): >/test ci/prow/e2e-azurestack-upi Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
gpei commented 2 weeks ago

/test e2e-azurestack-upi

jinyunma commented 2 weeks ago

Installation in Job e2e-azurestack-upi failed because of bug https://issues.redhat.com/browse/OCPBUGS-43823, worker nodes were provisioned successfully.

@patrickdillon @r4f4 could you help to review? thanks.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/installer/blob/master/OWNERS)~~ [r4f4] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 5e705f0f658f4030865683bee11bc0e45bf61cfb and 2 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 5e705f0f658f4030865683bee11bc0e45bf61cfb and 2 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

jinyunma commented 1 week ago

/test e2e-azure-ovn-upi

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 5e705f0f658f4030865683bee11bc0e45bf61cfb and 2 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 8942ab8605bc51d50158bccf772a3692e390d892 and 1 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD a892cbd47c53db141381d2cb8172f34a2dc63c30 and 2 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 11aa461e7e4e78223c474b0a5978744572b1c05d and 1 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD aa707636402238f899f450caf8d2b5a3a8fe518e and 0 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD aa707636402238f899f450caf8d2b5a3a8fe518e and 2 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD a04f578f3f41cfedf0f847c59d487c49e55347c1 and 1 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD a04f578f3f41cfedf0f847c59d487c49e55347c1 and 2 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

jinyunma commented 1 week ago

seems job e2e-azure-ovn-upi persistently failed because of two e2e failures. @r4f4 Is it possible to override this job?

r4f4 commented 1 week ago

/label acknowledge-critical-fixes-only

r4f4 commented 1 week ago

/override ci/prow/e2e-azure-ovn-upi

openshift-ci[bot] commented 1 week ago

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn-upi

In response to [this](https://github.com/openshift/installer/pull/9204#issuecomment-2488058140): >/override ci/prow/e2e-azure-ovn-upi Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 0f78927350d769bb8142d0eb1a56a1b01660fa46 and 2 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 5430fc9f4bd5f2febd19cf2b8810aa3855379585 and 1 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 0ebb11c1a2c204b1bd60aba5862332e12f692d31 and 0 for PR HEAD 405bd5e01282727914c9e446609703120a500a86 in total

openshift-ci[bot] commented 1 week ago

@jinyunma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-upi 405bd5e01282727914c9e446609703120a500a86 link false /test e2e-azurestack-upi
ci/prow/okd-scos-e2e-aws-ovn 405bd5e01282727914c9e446609703120a500a86 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azurestack 405bd5e01282727914c9e446609703120a500a86 link false /test e2e-azurestack
ci/prow/e2e-azure-ovn-upi 405bd5e01282727914c9e446609703120a500a86 link true /test e2e-azure-ovn-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 week ago

/hold

Revision 405bd5e01282727914c9e446609703120a500a86 was retested 3 times: holding