Closed zaneb closed 6 days ago
@zaneb: This pull request references CORS-3753 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.17." or "openshift-4.17.", but it targets "4.18.0" instead.
/label backport-risk-assessed /cc @patrickdillon
As discussed, I will manually apply the valid-bug label. We are backporting this on the grounds that it affects internal APIs for unit tests only.
@zaneb: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-azurestack | 80bc5a8378330a10099b7fb263f05c1fc43f15f9 | link | false | /test e2e-azurestack |
Full PR test history. Your PR dashboard.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sadasu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/label cherry-pick-approved
/lgtm
/retest-required
Remaining retests: 0 against base HEAD 147f4d9a92750d243b1edbd77d08cd32ec71f795 and 2 for PR HEAD 80bc5a8378330a10099b7fb263f05c1fc43f15f9 in total
[ART PR BUILD NOTIFIER]
Distgit: ose-installer-altinfra This PR has been included in build ose-installer-altinfra-container-v4.17.0-202411222304.p0.g7cb16ac.assembly.stream.el9. All builds following this will include this PR.
[ART PR BUILD NOTIFIER]
Distgit: ose-baremetal-installer This PR has been included in build ose-baremetal-installer-container-v4.17.0-202411222304.p0.g7cb16ac.assembly.stream.el9. All builds following this will include this PR.
[ART PR BUILD NOTIFIER]
Distgit: ose-installer-terraform-providers This PR has been included in build ose-installer-terraform-providers-container-v4.17.0-202411222304.p0.g7cb16ac.assembly.stream.el9. All builds following this will include this PR.
[ART PR BUILD NOTIFIER]
Distgit: ose-installer-artifacts This PR has been included in build ose-installer-artifacts-container-v4.17.0-202411222304.p0.g7cb16ac.assembly.stream.el9. All builds following this will include this PR.
Currently the Azure client can only be mocked in unit tests of the
pkg/asset/installconfig/azure
package. Using the mockable interface consistently and adding a public interface to set it up will allow other packages to write unit tests for code involving the Azure client.This is a backport from #9201