search

openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

CORS-2508: aws: remove unused autoscaling:DescribeAutoScalingGroups perm #9223

Open r4f4 opened 1 week ago

r4f4 commented 1 week ago

With the analysis from https://issues.redhat.com/browse/SPLAT-1844, the permission is required by the installer but never used.

openshift-ci-robot commented 1 week ago

@r4f4: This pull request references CORS-2508 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/installer/pull/9223): >With the analysis from https://issues.redhat.com/browse/SPLAT-1844, the permission is required by the installer but never used. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
r4f4 commented 1 week ago

/label platform/aws

r4f4 commented 1 week ago

/retest

sadasu commented 1 week ago

/approve

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/asset/installconfig/aws/OWNERS](https://github.com/openshift/installer/blob/master/pkg/asset/installconfig/aws/OWNERS)~~ [sadasu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sadasu commented 1 day ago

/retest

Retesting both the CIs that test AWS edge instances.

sadasu commented 1 day ago

/retest

Retesting both the CIs that test AWS edge instances.

I see that these failures are being worked on in different bugs.

openshift-ci[bot] commented 1 day ago

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones 63ea6b3f3aa057309a896d3a728d4b576cc59926 link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-aws-ovn-edge-zones 63ea6b3f3aa057309a896d3a728d4b576cc59926 link false /test e2e-aws-ovn-edge-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).