openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

RFE-6763: pkg/infrastructure/azure: support nvme #9232

Open patrickdillon opened 6 days ago

patrickdillon commented 6 days ago

Updates the installer-generated image definition to indicate support for NVME (and SCSI) disk controllers. Without this feature on the image definition, certain VM families will fail to provision with a message such as:

The VM size 'Standard_D8ds_v6' cannot boot with OS image or disk. Please check that disk controller types supported by the OS image or disk is one of the supported disk controller types for the VM size 'Standard_D8ds_v6'.

With the change in this commit, the VM will successfully provision.

openshift-ci-robot commented 6 days ago

@patrickdillon: This pull request references RFE-6763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/installer/pull/9232): >Updates the installer-generated image definition to indicate support for NVME (and SCSI) disk controllers. Without this feature on the image definition, certain VM families will fail to provision with a message such as: > >> The VM size 'Standard_D8ds_v6' cannot boot with OS image or disk. Please check that disk controller types supported by the OS image or disk is one of the supported disk controller types for the VM size 'Standard_D8ds_v6'. > >With the change in this commit, the VM will successfully provision. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from patrickdillon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/installer/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 6 days ago

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6d7d4af51882ac21215e5e7bb81d08e5a17ca51a link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azurestack 6d7d4af51882ac21215e5e7bb81d08e5a17ca51a link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).