search

openshift / oadp-operator

OADP Operator
Apache License 2.0
77 stars 70 forks source link

use the multiarch build of mariadb-todolist #1493

Closed weshayutin closed 1 month ago

weshayutin commented 1 month ago

Current source for this image is: https://github.com/weshayutin/todolist-mariadb-go.git quay.io/migtools/oadp-ci-todolist-mariadb-go:multiarch

This is an updated version that is cleaned up a bit and also works with VM's or with containers. Will push to migtools when this is passing.

Why the changes were made

How to test the changes made

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/e2e/OWNERS](https://github.com/openshift/oadp-operator/blob/master/tests/e2e/OWNERS)~~ [weshayutin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
weshayutin commented 1 month ago

/retest

weshayutin commented 1 month ago

all tests failed with same error, which I never saw before, in two vol test

@mateusoliveira43 looks like this exposed an error in our testing. The old mysql-todolist containers always created some sample data in the db, 2 rows. This version leaves the DB empty when we start up.

AFICT it looks like we're checking what data is in the db prior to adding any data. Not sure sure yet. That's my guess

2024/08/15 14:14:25 Data before the curl request: 
 []

2024/08/15 14:14:25 Payload encoded parameters: description=2024-08-15+14%3A14%3A25.114899618+%2B0000+UTC+m%3D%2B898.006557829
2024/08/15 14:14:25 Payload encoded parameters: description=Thursday
2024/08/15 14:14:25 Writing data to backupFile (backup-data.txt): 
 [{"Id":1,"Description":"2024-08-15 14:14:25.114899618 +0000 UTC m=+898.006557829","Completed":false},{"Id":2,"Description":"Thursday","Completed":false}]

or perhaps the post of the data before the backup is not working, looking again that seems more likely.

weshayutin commented 1 month ago

updated image /retest

weshayutin commented 1 month ago

well this is interesting.. Screenshot from 2024-08-15 15-54-18

weshayutin commented 1 month ago

/retest

kaovilai commented 1 month ago

Once the image are identical, I would push for latest to be multiarch.. and not separate tag.

mpryc commented 1 month ago

Once the image are identical, I would push for latest to be multiarch.. and not separate tag.

I will second that. With a single multi-arch image, users and developers don't need to worry about which specific tag corresponds to which architecture. Secondly having separate multi-arch tag rather then latest is less clear on what is the tag about? Is the multiarch build out of stable/branch or latest? That's not really clear.

I can quickly check what arch is supported by the image by calling podman manifest inspect <image>, but it's much harder to tell what the image corresponds to e.g.

podman manifest inspect quay.io/migtools/oadp-ci-todolist-mariadb-go:multiarch

[...]

{
    "schemaVersion": 2,
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "manifests": [
        {
            "mediaType": "application/vnd.oci.image.manifest.v1+json",
            "size": 814,
            "digest": "sha256:4623b177778d720f3707ef9f9e652e7bb671afea05896c03be4f1611121ec025",
            "platform": {
                "architecture": "arm64",
                "os": "linux"
            }
        },
        {
            "mediaType": "application/vnd.oci.image.manifest.v1+json",
            "size": 814,
            "digest": "sha256:c05264eda64207e0251dc4b69a71e399ac6e08c2836bff5d5561921de2ab87ad",
            "platform": {
                "architecture": "amd64",
                "os": "linux"
            }
        }
    ]
}
weshayutin commented 1 month ago

Once the image are identical, I would push for latest to be multiarch.. and not separate tag.

100% just consider that multiarch tag as a test :)

mpryc commented 1 month ago

/retest ci/prow/4.14-e2e-test-aws

openshift-ci[bot] commented 1 month ago

@mpryc: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/oadp-operator/pull/1493#issuecomment-2293518975): >/retest ci/prow/4.14-e2e-test-aws Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mpryc commented 1 month ago

/test 4.14-e2e-test-aws

weshayutin commented 1 month ago

Updated tags https://quay.io/repository/migtools/oadp-ci-todolist-mariadb-go?tab=tags multiarch is now tagged as latest :) PR to konveyor/mig-demo-apps https://github.com/konveyor/mig-demo-apps/pull/105