search

openshift / oadp-operator

OADP Operator
Apache License 2.0
77 stars 70 forks source link

Create templates `tests/e2e/sample-applications` #1531

Open mateusoliveira43 opened 2 days ago

mateusoliveira43 commented 2 days ago

To avoid duplication, we need to create OpenShift Templates for tests/e2e/sample-applications. This will also make it easier to create the applications for manual tests

Example

Today, developer must run two command to deploy an application, one to create application's PVCs (https://github.com/openshift/oadp-operator/blob/master/tests/e2e/sample-applications/mysql-persistent/pvc-twoVol/aws.yaml) and other for the other objects (https://github.com/openshift/oadp-operator/blob/master/tests/e2e/sample-applications/mysql-persistent/mysql-persistent-twovol-csi.yaml). And if developer want to use an different storageClassName, it need to manually edit the YAML files.

With OpenShift Template, it easy to create all object at once and easy modify its parameters. Example https://github.com/migtools/oadp-non-admin/blob/master/hack/samples/apps/mysql.yaml

Failed approach

Tried in https://github.com/openshift/oadp-operator/pull/1364, but approach would make developers running it harder (they would need to change replace strings manually).