Closed aguidirh closed 1 month ago
@aguidirh: This pull request references OCPSTRAT-1439 which is a valid jira issue.
This pull request references CLID-28 which is a valid jira issue.
This pull request references CLID-170 which is a valid jira issue.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aguidirh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test images
/test unit
@aguidirh I'm going through the code and then verifying using sonarqube
@aguidirh Executed against sonarqube - code coverage is at 74.6% - but its no big deal, as overall we are still at 80% (which meets our agreed AC on code coverage)
Cognitive complexity is high , but honestly in all our logic the value has always been high. No other issues regarding Clean Code attributes - Consistency, Intentionality, Adaptability, Responsibility and under Sofware Quality - Security, Reliability, Maintainability no issues.
Overall looks good
I'm happy to give it a LGTM
/lgtm
@aguidirh: all tests passed!
Full PR test history. Your PR dashboard.
Description
This PR adds the feature to mirror helm charts in oc-mirror v2.
Jira issues: OCPSTRAT-1439 CLID-28 CLID-170
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
With the following ImageSetConfiguration
Run all flows (mirrorToDisk, diskToMirror and mirrorToMirror)
mirrorToDisk
diskToMirror
mirrorToMirror
Expected Outcome
All flows should finish successfully and the images should be in the target registry as showed below:
IDMS and ITMS should be generated as showed below:
IDMS
ITMS