search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
91 stars 82 forks source link

CLID-247: changes the tlsVerify default to true and adds helm tls support #936

Closed aguidirh closed 1 month ago

aguidirh commented 1 month ago

Description

This PR changes the tlsVerify default to true and adds helm tls support.

Fixes # (CLID-247)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Run all the workflows (mirrorToDisk, diskToMirror and mirrorToMirror) for releases, operators, additional images and helm charts.

When doing the mirrorToMirror or diskToMirror --dest-tls-verify=false should be included in case the target registry does not have the TLS enabled

Expected Outcome

All the flows (mirrorToDisk, diskToMirror and mirrorToMirror) should continue working for releases, operators, additional images, helm charts.

Also the delete should continue working (except for helm which is not implemented yet)

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [aguidirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-247 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/oc-mirror/pull/936): ># Description > >This PR changes the tlsVerify default to true and adds helm tls support. > >Fixes # ([CLID-247](https://issues.redhat.com/browse/CLID-247)) > >## Type of change > >Please delete options that are not relevant. > >- [ ] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [x] This change requires a documentation update > ># How Has This Been Tested? > >Run all the workflows (mirrorToDisk, diskToMirror and mirrorToMirror) for releases, operators, additional images and helm charts. > >When doing the mirrorToMirror or diskToMirror `--dest-tls-verify=false` should be included in case the target registry does not have the TLS enabled > >## Expected Outcome >All the flows (mirrorToDisk, diskToMirror and mirrorToMirror) should continue working for releases, operators, additional images, helm charts. > >Also the delete should continue working (except for helm which is not implemented yet) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aguidirh commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-247 which is a valid jira issue.

In response to [this](https://github.com/openshift/oc-mirror/pull/936#issuecomment-2416277224): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lmzuccarelli commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

@aguidirh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: oc-mirror-plugin This PR has been included in build oc-mirror-plugin-container-v4.18.0-202410171240.p0.gb3e9d21.assembly.stream.el9. All builds following this will include this PR.