search

openshift / ocp-release-operator-sdk

Apache License 2.0
16 stars 38 forks source link

[release-4.17] OCPBUGS-39204: V1.36.1 rebase release 4.17 #392

Closed arkadeepsen closed 3 weeks ago

arkadeepsen commented 1 month ago

Manual cherry-pick of #387

Followed the below steps:

openshift-ci-robot commented 1 month ago

@arkadeepsen: This pull request references Jira Issue OCPBUGS-39204, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/392): >Manual cherry-pick of #387 > >Followed the below steps: > >- Rebase to upstream v1.36.1 > > - Ran the following script to create the rebase branch: > > ``` > ./UPSTREAM-MERGE.sh v1.36.1 release-4.17 > ``` >Manually cherry-picked the following commits >- Regenerate 03-setversion.patch (a87ee6cb5139261a8b62816470fbafa9ba233264) >- Regenerate fixsanity patch (abd16bde54e64f0eae1b07ad00d8264c09777d25) >- Regenerate disable security context patch (2700f259801621e32b34f251bc6c7f6ef0df18a0) >- Regenerate 06-build-darwin-binary.patch (5c5075c1591095371940ca8c1ebc8e72dfd363f0) >- Regenerate 11-openshiftv1-cli.patch (2e1f7158a99442170becacd1e8ebef97d26c47de) >- Remove ansible code (a3930557b5cc34970399591997a3b175128f61a9) >- Update vendor directory (33361b4a230a2d688e1fa39f007e2efdca47a4c4) >- Set the value of GOBIN in e2e-helm.sh before "make install" of operator-sdk (94c408f056a4418e381839384648097f887e91f4) >- Update OCP version (5949f3ba4ec1f11f28173f3f2ef214e6b14dd982) and modified OCP version to 4.17 >- Update UBI minimal version (288e744fc419c3ef3c0aa977b886c35863f83370) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Focp-release-operator-sdk). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
arkadeepsen commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@arkadeepsen: This pull request references Jira Issue OCPBUGS-39204, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-37598](https://issues.redhat.com//browse/OCPBUGS-37598) is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-37598](https://issues.redhat.com//browse/OCPBUGS-37598) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @KeenonLee

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/392#issuecomment-2317667559): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Focp-release-operator-sdk). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
arkadeepsen commented 1 month ago

/cc @TrilokGeer @chiragkyal

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkadeepsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocp-release-operator-sdk/blob/release-4.17/OWNERS)~~ [arkadeepsen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chiragkyal commented 1 month ago

/lgtm

arkadeepsen commented 1 month ago

/hold There's some issue with release image for 4.18: https://redhat-internal.slack.com/archives/CB95J6R4N/p1725000287781299

openshift-ci-robot commented 3 weeks ago

@arkadeepsen: This pull request references Jira Issue OCPBUGS-39204, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-37598](https://issues.redhat.com//browse/OCPBUGS-37598) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-37598](https://issues.redhat.com//browse/OCPBUGS-37598) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @KeenonLee

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/392): >Manual cherry-pick of #387 > >Followed the below steps: > >- Rebase to upstream v1.36.1 > > - Ran the following script to create the rebase branch: > > ``` > ./UPSTREAM-MERGE.sh v1.36.1 release-4.17 > ``` >Manually cherry-picked the following commits >- Regenerate 03-setversion.patch (a87ee6cb5139261a8b62816470fbafa9ba233264) >- Regenerate fixsanity patch (abd16bde54e64f0eae1b07ad00d8264c09777d25) >- Regenerate disable security context patch (2700f259801621e32b34f251bc6c7f6ef0df18a0) >- Regenerate 06-build-darwin-binary.patch (5c5075c1591095371940ca8c1ebc8e72dfd363f0) >- Regenerate 11-openshiftv1-cli.patch (2e1f7158a99442170becacd1e8ebef97d26c47de) >- Remove ansible code (a3930557b5cc34970399591997a3b175128f61a9) >- Update vendor directory (33361b4a230a2d688e1fa39f007e2efdca47a4c4) >- Set the value of GOBIN in e2e-helm.sh before "make install" of operator-sdk (94c408f056a4418e381839384648097f887e91f4) >- Update OCP version (5949f3ba4ec1f11f28173f3f2ef214e6b14dd982) and modified OCP version to 4.17 >- Update UBI minimal version (288e744fc419c3ef3c0aa977b886c35863f83370) >- Remove unused symlink of Dockerfile (615e06e935e43e198339eb2a2073975d12a41f5c) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Focp-release-operator-sdk). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 weeks ago

@arkadeepsen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
arkadeepsen commented 3 weeks ago

/hold cancel https://github.com/openshift/ocp-release-operator-sdk/pull/394 was used to successfully build operator-sdk and helm-operator images. Ref: https://github.com/openshift/ocp-release-operator-sdk/pull/394#issuecomment-2338487115 & https://github.com/openshift/ocp-release-operator-sdk/pull/394#issuecomment-2338494097.

TrilokGeer commented 3 weeks ago

/lgtm

TrilokGeer commented 3 weeks ago

/label backport-risk-assessed

openshift-ci-robot commented 3 weeks ago

@arkadeepsen: Jira Issue OCPBUGS-39204: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-39204 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/392): >Manual cherry-pick of #387 > >Followed the below steps: > >- Rebase to upstream v1.36.1 > > - Ran the following script to create the rebase branch: > > ``` > ./UPSTREAM-MERGE.sh v1.36.1 release-4.17 > ``` >Manually cherry-picked the following commits >- Regenerate 03-setversion.patch (a87ee6cb5139261a8b62816470fbafa9ba233264) >- Regenerate fixsanity patch (abd16bde54e64f0eae1b07ad00d8264c09777d25) >- Regenerate disable security context patch (2700f259801621e32b34f251bc6c7f6ef0df18a0) >- Regenerate 06-build-darwin-binary.patch (5c5075c1591095371940ca8c1ebc8e72dfd363f0) >- Regenerate 11-openshiftv1-cli.patch (2e1f7158a99442170becacd1e8ebef97d26c47de) >- Remove ansible code (a3930557b5cc34970399591997a3b175128f61a9) >- Update vendor directory (33361b4a230a2d688e1fa39f007e2efdca47a4c4) >- Set the value of GOBIN in e2e-helm.sh before "make install" of operator-sdk (94c408f056a4418e381839384648097f887e91f4) >- Update OCP version (5949f3ba4ec1f11f28173f3f2ef214e6b14dd982) and modified OCP version to 4.17 >- Update UBI minimal version (288e744fc419c3ef3c0aa977b886c35863f83370) >- Remove unused symlink of Dockerfile (615e06e935e43e198339eb2a2073975d12a41f5c) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Focp-release-operator-sdk). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-operator-sdk This PR has been included in build openshift-enterprise-operator-sdk-container-v4.17.0-202409100034.p0.g75a6507.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-helm-operator This PR has been included in build openshift-enterprise-helm-operator-container-v4.17.0-202409100034.p0.g75a6507.assembly.stream.el9. All builds following this will include this PR.