openshift / openshift-docs

OpenShift 3 and 4 product and community documentation
https://docs.openshift.com
Apache License 2.0
763 stars 1.77k forks source link

OCPBUGS-44418: Generalize install-config.yaml path to use variable directory #85544

Open MrSanketkumar opened 4 days ago

MrSanketkumar commented 4 days ago

Version(s): 4.12

Issue: [Jira Ticket](https://issues.redhat.com/browse/OCPBUGS-44418)

Link to docs preview:

QE review:

Additional information: The installation process uses a placeholder for the directory name in one part, but later it is hardcoded as "my-cluster" in another, which can lead to mismatches if the actual directory name differs from the hardcoded value.

https://github.com/openshift/openshift-docs/pull/84713

openshift-ci-robot commented 4 days ago

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-44418, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/openshift-docs/pull/85544): > > > > >Version(s): 4.12 > > >Issue: [Jira Ticket](https://issues.redhat.com/browse/OCPBUGS-44418) > > >Link to docs preview: > > >QE review: >- [x] QE has approved this change. > > >Additional information: >The installation process uses a **placeholder** for the directory name in one part, but later it is **hardcoded as "my-cluster"** in another, which can lead to mismatches if the actual directory name differs from the hardcoded value. > >https://github.com/openshift/openshift-docs/pull/84713 > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-docs). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 days ago

Hi @MrSanketkumar. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
MrSanketkumar commented 4 days ago

/jira refresh

openshift-ci-robot commented 4 days ago

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-44418, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/openshift-docs/pull/85544#issuecomment-2503899444): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-docs). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
MrSanketkumar commented 4 days ago

/jira refresh

openshift-ci-robot commented 4 days ago

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-44418, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/openshift-docs/pull/85544#issuecomment-2503903030): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-docs). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.