openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.48k stars 4.69k forks source link

Router should be accept proxy protocol on port 1936 #17619

Open jkroepke opened 6 years ago

jkroepke commented 6 years ago

I'm using on the AWS the new NLB for loadbalancing the router.

AWS supports the proxy protocol days ago. I configure the IP:1936/healthz as healthcheck.

If the target group of the loadbalancer has active proxy protocol, the healthcheck are fired with proxy protocol, too. Since the port 1936 is handeld by the openshift-router process, it must be accept the proxy protocol to response valid answers for the loadbalancer.

Version

oc version

oc v3.7.0+7ed6862 kubernetes v1.7.6+a08f5eeb62 features: Basic-Auth GSSAPI Kerberos SPNEGO

Server openshift v3.7.0+7ed6862 kubernetes v1.7.6+a08f5eeb62

Steps To Reproduce
  1. Setup a multiple Openshift Routers with active PROXY_PROTOCOL support.
  2. In AWS, setup a network loadbalancer, a target group (use ip as target instead instances!), define the healthcheck to HTTP:1936/healthz and enable the proxy protocol
Current Result

After some minutes, the health status will be unhealthy

Expected Result

All Target should be healthy

openshift-bot commented 6 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

jkroepke commented 6 years ago

/remove-lifecycle stale

jkroepke commented 6 years ago

@knobunc Any idea?

openshift-bot commented 6 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

jkroepke commented 6 years ago

/remove-lifecycle stale

jkroepke commented 6 years ago

/lifecycle frozen