search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.5k stars 4.7k forks source link

OCPBUGS-39363: Reenable Rails tests and update the sample repos test to support deployments #29097

Closed metlos closed 2 months ago

metlos commented 2 months ago

After a change of decision about the support for Rails, we need to reenable it in the Samples Operator and therefore also in the integration tests here.

In addition to re-enabling the dedicated ruby test, we also need to support this in the samples_repo tests. Because the rails template now uses Deployments instead of DeploymentConfigs, it was also needed to add support for that in the tests.

openshift-ci-robot commented 2 months ago

@metlos: This pull request references Jira Issue OCPBUGS-39363, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin/pull/29097): >After a change of decision about the support for Rails, we need to reenable it in the Samples Operator and therefore also in the integration tests here. > >In addition to re-enabling the dedicated ruby test, we also need to support this in the samples_repo tests. Because the rails template now uses Deployments instead of DeploymentConfigs, it was also needed to add support for that in the tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
metlos commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@metlos: This pull request references Jira Issue OCPBUGS-39363, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jitendar-singh

In response to [this](https://github.com/openshift/origin/pull/29097#issuecomment-2345769441): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
metlos commented 2 months ago

/test e2e-gcp-ovn-image-ecosystem

ausil commented 2 months ago

/lgtm

metlos commented 2 months ago

Note that the e2e-gcp-ovn-image-ecosystem test should fail because of a problem in perl template (addressed https://github.com/openshift/origin/pull/29096) but the tests for Rails should both pass.

metlos commented 2 months ago

/retest

openshift-trt-bot commented 2 months ago

Job Failure Risk Analysis for sha: 1b0b8c3fdb52e7b364e5558784f258c1242a7871

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade IncompleteTests
Tests for this run (191) are below the historical average (739): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (1132) are below the historical average (2232): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-serial IncompleteTests
Tests for this run (102) are below the historical average (774): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
metlos commented 2 months ago

/retest

metlos commented 2 months ago

/retest

openshift-trt-bot commented 2 months ago

Job Failure Risk Analysis for sha: bbb5fa8fdc38d09e306fad3928b159a8d7a5bbc8

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[bz-kube-apiserver][invariant] alert/KubeAPIErrorBudgetBurn should not be at or above info
This test has passed 99.44% of 6995 runs on release 4.18 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial High
[sig-arch] events should not repeat pathologically for ns/openshift-ovn-kubernetes
This test has passed 100.00% of 53 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days.
---
[bz-Management Console] clusteroperator/console should not change condition/Available
This test has passed 100.00% of 53 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days.

Open Bugs
clusteroperator/console: unexpected state transitions during e2e test run
---
[sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers for ns/openshift-multus
This test has passed 100.00% of 53 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days.
metlos commented 2 months ago

/retest

fbm3307 commented 2 months ago

/lgtm

metlos commented 2 months ago

/retest

metlos commented 2 months ago

/assign @dennisperiquet

metlos commented 2 months ago

/test e2e-gcp-ovn-image-ecosystem

openshift-trt-bot commented 2 months ago

Job Failure Risk Analysis for sha: 6dd82a2deae08000d18f20a7397647834770351c

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade Medium
[sig-api-machinery] disruption/openshift-api connection/reused should be available throughout the test
This test has passed 97.10% of 5455 runs on release 4.18 [Overall] in the last week.
---
[sig-api-machinery] disruption/kube-api connection/new should be available throughout the test
This test has passed 88.38% of 198 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.
---
[sig-api-machinery] disruption/openshift-api connection/new should be available throughout the test
This test has passed 97.47% of 198 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.
---
[sig-api-machinery] disruption/oauth-api connection/reused should be available throughout the test
This test has passed 92.42% of 198 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.
---
Showing 4 of 6 test results
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Medium
[sig-node] static pods should start after being created
This test has passed 94.64% of 56 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-single-node-serial'] in the last 14 days.

Open Bugs
Static pod controller pods sometimes fail to start
ausil commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ausil, fbm3307, metlos Once this PR has been reviewed and has the lgtm label, please ask for approval from dennisperiquet. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@metlos: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd 212968f4a7a0a30c906afd82512bbc3404d2c3a3 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-upgrade 212968f4a7a0a30c906afd82512bbc3404d2c3a3 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-upgrade 212968f4a7a0a30c906afd82512bbc3404d2c3a3 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-ipsec-serial 212968f4a7a0a30c906afd82512bbc3404d2c3a3 link false /test e2e-aws-ovn-ipsec-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-trt-bot commented 2 months ago

Job Failure Risk Analysis for sha: 212968f4a7a0a30c906afd82512bbc3404d2c3a3

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade Medium
[sig-api-machinery] disruption/kube-api connection/reused should be available throughout the test
This test has passed 87.70% of 187 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.
---
[sig-api-machinery] disruption/oauth-api connection/reused should be available throughout the test
This test has passed 91.98% of 187 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.
---
[sig-api-machinery] disruption/kube-api connection/new should be available throughout the test
This test has passed 87.70% of 187 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.
---
[sig-api-machinery] disruption/oauth-api connection/new should be available throughout the test
This test has passed 91.98% of 187 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.
metlos commented 2 months ago

I'm closing this in favor of https://github.com/openshift/origin/pull/29116.

openshift-ci-robot commented 2 months ago

@metlos: This pull request references Jira Issue OCPBUGS-39363. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin/pull/29097): >After a change of decision about the support for Rails, we need to reenable it in the Samples Operator and therefore also in the integration tests here. > >In addition to re-enabling the dedicated ruby test, we also need to support this in the samples_repo tests. Because the rails template now uses Deployments instead of DeploymentConfigs, it was also needed to add support for that in the tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.