search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.5k stars 4.7k forks source link

NO-JIRA: images.sh: Do not rely on the tag order #29104

Closed ardaguclu closed 2 months ago

ardaguclu commented 2 months ago

ImageStreams object's tag order seems to be changed and this test fully relies on the first object of the tag list and it is perma-failing https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_oc/1877/pull-ci-openshift-oc-master-e2e-agnostic-ovn-cmd/1834521049262198784. This PR modifies the test by searching for the perl 5.32 image in the list instead of checking the first item.

openshift-ci-robot commented 2 months ago

@ardaguclu: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/29104): >ImageStreams object's tag order seems to be changed and this test fully relies on the first object of the tag list. This PR modifies the test by searching for the perl 5.32 image in the list instead of checking the first item. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ardaguclu Once this PR has been reviewed and has the lgtm label, please assign dennisperiquet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ardaguclu commented 2 months ago

Once this https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29104/pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd/1834562450733666304 passes, this PR is ready to merge.

ardaguclu commented 2 months ago

/test e2e-agnostic-ovn-cmd

ardaguclu commented 2 months ago

/test ci/prow/unit /test ci/prow/e2e-agnostic-ovn-cmd

openshift-ci[bot] commented 2 months ago

@ardaguclu: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/origin/pull/29104#issuecomment-2352305800): >/test ci/prow/unit >/test ci/prow/e2e-agnostic-ovn-cmd Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ardaguclu commented 2 months ago

/test unit /test e2e-agnostic-ovn-cmd

ardaguclu commented 2 months ago

This revert https://github.com/openshift/origin/pull/29105 should fix it; /close

openshift-ci[bot] commented 2 months ago

@ardaguclu: Closed this PR.

In response to [this](https://github.com/openshift/origin/pull/29104#issuecomment-2352521810): >This revert https://github.com/openshift/origin/pull/29105 should fix it; >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade d35f49cdbc323cda377888be41089979d3c07a90 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-kube-apiserver-rollout d35f49cdbc323cda377888be41089979d3c07a90 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout d35f49cdbc323cda377888be41089979d3c07a90 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node d35f49cdbc323cda377888be41089979d3c07a90 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-ipsec-serial d35f49cdbc323cda377888be41089979d3c07a90 link false /test e2e-aws-ovn-ipsec-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).