search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.5k stars 4.7k forks source link

TRT-1823: Revert #29087 "NO-JIRA: improve excessive restart tests" #29107

Closed stbenjam closed 2 months ago

stbenjam commented 2 months ago

Reverts #29087 ; tracked by TRT-1823

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

These test cases are generating tests with dynamic namespace names in them, this breaks a lot of tooling including aggregation

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Run /payload blocking jobs to verify aggregation passes

CC: @kannon92

PR created by Revertomatic:tm:
openshift-ci-robot commented 2 months ago

@stbenjam: This pull request references TRT-1823 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/29107): > >Reverts #29087 ; tracked by [TRT-1823](https://issues.redhat.com//browse/TRT-1823) > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >These test cases are generating tests with dynamic namespace names in them, this breaks a lot of tooling including aggregation > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >Run /payload blocking jobs to verify aggregation passes >``` > >CC: @kannon92 > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@stbenjam: This pull request references TRT-1823 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/29107): > >Reverts #29087 ; tracked by [TRT-1823](https://issues.redhat.com//browse/TRT-1823) > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >These test cases are generating tests with dynamic namespace names in them, this breaks a lot of tooling including aggregation > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >Run /payload blocking jobs to verify aggregation passes >``` > >CC: @kannon92 > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
stbenjam commented 2 months ago

/override ci/prow/e2e-gcp-csi /override ci/prow/e2e-aws-ovn-single-node /override ci/prow/e2e-agnostic-ovn-cmd /override ci/prow/e2e-aws-ovn-serial /override ci/prow/e2e-aws-ovn-microshift-serial /override ci/prow/e2e-aws-ovn-microshift /override ci/prow/e2e-aws-ovn-kube-apiserver-rollout /override ci/prow/e2e-aws-ovn-ipsec-serial /override ci/prow/e2e-aws-ovn-fips /override ci/prow/e2e-aws-ovn-single-node-upgrade /override ci/prow/e2e-aws-ovn-cgroupsv2 /override ci/prow/e2e-aws-ovn-single-node-serial /override ci/prow/e2e-aws-csi /override ci/prow/e2e-aws-ovn-upgrade /override ci/prow/e2e-aws-ovn-edge-zones

openshift-ci[bot] commented 2 months ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-edge-zones, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-ipsec-serial, ci/prow/e2e-aws-ovn-kube-apiserver-rollout, ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi

In response to [this](https://github.com/openshift/origin/pull/29107#issuecomment-2355604837): >/override ci/prow/e2e-gcp-csi >/override ci/prow/e2e-aws-ovn-single-node >/override ci/prow/e2e-agnostic-ovn-cmd >/override ci/prow/e2e-aws-ovn-serial >/override ci/prow/e2e-aws-ovn-microshift-serial >/override ci/prow/e2e-aws-ovn-microshift >/override ci/prow/e2e-aws-ovn-kube-apiserver-rollout >/override ci/prow/e2e-aws-ovn-ipsec-serial >/override ci/prow/e2e-aws-ovn-fips >/override ci/prow/e2e-aws-ovn-single-node-upgrade >/override ci/prow/e2e-aws-ovn-cgroupsv2 >/override ci/prow/e2e-aws-ovn-single-node-serial >/override ci/prow/e2e-aws-csi >/override ci/prow/e2e-aws-ovn-upgrade >/override ci/prow/e2e-aws-ovn-edge-zones Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
stbenjam commented 2 months ago

/skip

dgoodwin commented 2 months ago

/lgtm

stbenjam commented 2 months ago

/override ci/prow/e2e-gcp-ovn-upgrade /override ci/prow/e2e-gcp-ovn

stbenjam commented 2 months ago

/override ci/prow/e2e-gcp-ovn-upgrade /override ci/prow/e2e-gcp-ovn

openshift-ci[bot] commented 2 months ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade

In response to [this](https://github.com/openshift/origin/pull/29107#issuecomment-2355686266): >/override ci/prow/e2e-gcp-ovn-upgrade >/override ci/prow/e2e-gcp-ovn Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dgoodwin commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [dgoodwin,stbenjam] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stbenjam commented 2 months ago

/override ci/prow/e2e-metal-ipi-ovn-ipv6

openshift-ci[bot] commented 2 months ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to [this](https://github.com/openshift/origin/pull/29107#issuecomment-2355752295): >/override ci/prow/e2e-metal-ipi-ovn-ipv6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202409171613.p0.gd83d6ac.assembly.stream.el9. All builds following this will include this PR.